Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid conflict with attributes named value when flattening extensions #1085

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Nov 3, 2024

📒 Description

When we flatten simple type extensions, we create a default text node value attr. If the model includes an attribute field with name "value", the whole thing fails.

Resolves #1084

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

sonarqubecloud bot commented Nov 3, 2024

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dd587cd) to head (fb907cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1085   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         9276      9276           
  Branches      1417      1417           
=========================================
  Hits          9276      9276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit 827210b into main Nov 3, 2024
13 of 14 checks passed
@tefra tefra deleted the fix-value-attr-conflict branch November 3, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

value in XML element attributes is colliding with implicit name("value") for value in data classes
1 participant