Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SerializerConfig #321

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Introduce SerializerConfig #321

merged 1 commit into from
Nov 21, 2020

Conversation

tefra
Copy link
Owner

@tefra tefra commented Nov 21, 2020

Notes:

This is breaking backwards compatibility, but it was time to introduce the serializer config.

Notes:
- Resolves #320 #268
- Unify xml declaration for all writes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #321 (122830c) into master (cb243df) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #321   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        70    +1     
  Lines         5613      5636   +23     
  Branches       979       982    +3     
=========================================
+ Hits          5613      5636   +23     
Impacted Files Coverage Δ
...data/formats/dataclass/serializers/writers/lxml.py 100.00% <ø> (ø)
xsdata/formats/dataclass/serializers/config.py 100.00% <100.00%> (ø)
xsdata/formats/dataclass/serializers/mixins.py 100.00% <100.00%> (ø)
...ta/formats/dataclass/serializers/writers/native.py 100.00% <100.00%> (ø)
xsdata/formats/dataclass/serializers/xml.py 100.00% <100.00%> (ø)
xsdata/models/config.py 100.00% <100.00%> (ø)
xsdata/models/enums.py 100.00% <100.00%> (ø)
xsdata/models/xsd.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb243df...122830c. Read the comment docs.

@tefra tefra merged commit 7a0da69 into master Nov 21, 2020
@tefra tefra deleted the serializer-config branch November 21, 2020 20:29
@tefra tefra restored the serializer-config branch November 21, 2020 20:40
@tefra tefra deleted the serializer-config branch November 21, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noNamespaceSchemaLocation?
1 participant