Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicate global types earlier #411

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Merge duplicate global types earlier #411

merged 1 commit into from
Feb 25, 2021

Conversation

tefra
Copy link
Owner

@tefra tefra commented Feb 16, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #411 (4fc1ed8) into master (09984ea) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #411   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         6561      6559    -2     
  Branches      1161      1160    -1     
=========================================
- Hits          6561      6559    -2     
Impacted Files Coverage Δ
xsdata/codegen/handlers/class_extension.py 100.00% <ø> (ø)
xsdata/codegen/models.py 100.00% <ø> (ø)
xsdata/codegen/validator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09984ea...4fc1ed8. Read the comment docs.

@tefra tefra force-pushed the issue-406 branch 3 times, most recently from 0de6251 to 6fe4c5f Compare February 25, 2021 21:04
@tefra tefra changed the title Avoid flattening duplicate complex types Merge duplicate global types earlier Feb 25, 2021
Note:
This also reverses the previous behavior
tha favored the element and flattened the
complex type. The reason being complex
types can be used as base classes.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tefra tefra removed the wip label Feb 25, 2021
@tefra tefra merged commit 34c9aa2 into master Feb 25, 2021
@tefra tefra deleted the issue-406 branch February 25, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant