Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser config to load external dtd to resolve entities #797

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jun 5, 2023

📒 Description

Loading external dtd is supported by lxml we should expose this in the parser config.

Fixes #769

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a768eef) 99.96% compared to head (d75972e) 99.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #797   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         104      104           
  Lines        9208     9209    +1     
  Branches     2060     2060           
=======================================
+ Hits         9205     9206    +1     
  Partials        3        3           
Impacted Files Coverage Δ
xsdata/formats/dataclass/parsers/config.py 100.00% <100.00%> (ø)
xsdata/formats/dataclass/parsers/handlers/lxml.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tefra tefra merged commit 46a8fac into master Jun 5, 2023
@tefra tefra deleted the lxml-load-dtd-option branch June 5, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle entity definitions
1 participant