Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore xsi attrs when fail on unknown attributes is enabled #846

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented Aug 20, 2023

📒 Description

xsi:attributes should be ignored when we enable the parser config option fail_on_unknown_attributes

Resolves #845

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (31f672a) 99.89% compared to head (625a650) 99.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         104      104           
  Lines        9282     9284    +2     
  Branches     2076     2076           
=======================================
+ Hits         9272     9274    +2     
  Misses          3        3           
  Partials        7        7           
Files Changed Coverage Δ
xsdata/formats/dataclass/parsers/nodes/element.py 99.04% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit d47044e into main Aug 20, 2023
@tefra tefra deleted the fix-845 branch August 20, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xsi:attributes break parsing.
1 participant