Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to generate wrapper fields #982

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Add option to generate wrapper fields #982

merged 6 commits into from
Mar 21, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented Mar 20, 2024

📒 Description

Write a brief description of your PR.

Resolves #927

🔗 What I've Done

  • Support wrapper fields in json parser/serializer
  • Support non list wrapper fields
  • Add cli option to generate wrapper fields
  • Add class handler to generate the wrapper fields

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (b43b9c7) to head (15db7b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   99.95%   99.98%   +0.03%     
==========================================
  Files         115      116       +1     
  Lines        9043     9116      +73     
  Branches     2147     2166      +19     
==========================================
+ Hits         9039     9115      +76     
+ Misses          2        0       -2     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra added the wip label Mar 20, 2024
@tefra
Copy link
Owner Author

tefra commented Mar 20, 2024

We need a few more validations, sometimes I hate w3c test suite... but it's an awesome tool to avoid obvious mistakes

@tefra tefra force-pushed the generate-wrapper-fields branch 3 times, most recently from ede942c to 1371297 Compare March 21, 2024 13:33
@tefra tefra force-pushed the generate-wrapper-fields branch from 1371297 to 15db7b5 Compare March 21, 2024 13:51
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tefra tefra merged commit 059c607 into main Mar 21, 2024
14 checks passed
@tefra tefra deleted the generate-wrapper-fields branch March 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add option to infer wrapped lists when generating python code from XSD
1 participant