-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Handle tags case insensitive #334
Comments
I'll look into it when reviewing jag's PR tomorrow, I'm just not sure if its related to NGINX too Cc @Zir0h potentially, afaik React Router itself is but that's probably tweakable with a prop |
Hi! I had a look yesterday, it's related to hasura/postgres. The use of |
Making the graphql query case insensitive with |
I wonder if anything can be done on the underlying database to improve the performance. |
tag being of type "text" is probably not helping at all 😅 |
People who are using
|
"tag": "tezquakeaid" "tag": "TezQuakeAid" "tag": "#tezquakeaid" "tag": "#TezQuakeAid" It might be easiest to just drop the # character before we launch the query 😆 |
https://github.com/toluaina/pgsync looks pretty cool if we'd put an elasticsearch instance for the searching / tags etc |
https://github.com/teia-community/teia-ui/blob/main/src/components/tags/index.module.scss#L26 is probably also confusing people, tags get lowercased on the frontend but the link can be mixed case. |
Are there ways to optimize ilike? |
there's the and then there's the elasticsearch option, hasura seems to integrate with that pretty well, but I haven't tested the pgsync thingy that option would add a lot of overhead though, elasticsearch + sync containers (but it could be useful for site search too) |
we can also use
https://www.postgresql.org/docs/current/citext.html#CITEXT-HOW-TO-USE-IT |
Describe the problem
Artists can specify tags in any case, for example: Fear4Tez or fear4tez
However, clicking on the tag will result in different results which might not be the intention of the artist. For example, these give different results, but probably shouldn't: https://teia.art/tags/Fear4Tez vs https://teia.art/tags/fear4tez
Describe the solution you'd like
Handle tags case-insensitive
Alternatives considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: