-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subjkt settings [bug] #336
Comments
This is actually a duplicate of #303 |
Thanks but my question was about the Subjkt casing at the contract level |
I don't think so. The entry point takes bytes and i don't think it does any string manipulation. My guess is that is possible to register jagracar, Jagracar or JAGRACAR using better call dev. In fact, you can see some capitals here: I even find some recent ones with capitals. Maybe they were registered in one of the h=n forks. |
I think we already had this discussion but I can't recall the conclusions 😅 ! |
I don't think the smart contract is that clever. It just registers the name (in bytes) to the associated address. If the name exists already, it will throw an error. But that only happens if the name exactly the same in bytes. So capitals or not make a difference. Unfortunately there is no way to check the smarpy code for the SUBJKT contract, only the michelson code: |
Cool, so to address this issue, we should probably just correct it disallowing uppercase and let the user know, either by a popup or a field validation visual like a red border |
The problem is that if your wallet is assigned to mel and i assign mine to Mel using BCD, which page will be shown in the UI? Yours or mine? And what happens if you registered Mel before the filter took place in the UI? If i register mel, will my page be shown instead of yours? |
I think at some moment we might need to deploy our own SUBJKT contract with some of those problems fixed. |
Should we consider a solution that works across Tezos and not just for Teia? |
Indeed, because now we're just doing patchwork 😅 frontend sanitization is the same as no sanitization 😆 |
yeah, like https://forum.tezosagora.org/t/open-sourcing-and-decentralizing-tezid-profiles/5681 |
Describe the bug
When adding your subjkt details for a new wallet I found that the first letter of the chosen name is removed automatically if you use a capital e.g. 'Moments' is automatically changed to 'oments'. The biggest problem is it takes a few seconds for the auto recognition and removal of the capitalised letter which isn't obvious if you have moved on to filling out the next questions.
If you check at the wrong time you don't realise the issue before accepting the transaction.
Reproduction
Expected behavior
Make capitals useable if it's possible but otherwise make it autocorrect to lower case or have a notice show if it is deleted so you know to check maybe.
Platform and versions
Additional context
No response
The text was updated successfully, but these errors were encountered: