Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some nrf52 boards #3

Merged

Conversation

nordicjm
Copy link

WIP

@nordicjm nordicjm force-pushed the nrf52_adopt_soc_scheme_v2 branch 3 times, most recently from 87f451f to d570b60 Compare December 19, 2023 15:39
@nordicjm nordicjm changed the title Convert laird boards Convert some nrf52 boards Dec 19, 2023
@tejlmand tejlmand force-pushed the nrf52_adopt_soc_scheme_v2 branch 3 times, most recently from ba9e88f to 619ae19 Compare December 20, 2023 10:36
@nordicjm nordicjm force-pushed the nrf52_adopt_soc_scheme_v2 branch from aaf75d6 to c8b7ec6 Compare December 20, 2023 12:08
@tejlmand tejlmand force-pushed the nrf52_adopt_soc_scheme_v2 branch from 619ae19 to 5f87b4f Compare December 20, 2023 12:22
Adds missing SoCs from the v2 conversion

Signed-off-by: Jamie McCrae <[email protected]>
Adds support for determining the running from the identifier
which is needed for HWMv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm force-pushed the nrf52_adopt_soc_scheme_v2 branch from c8b7ec6 to 320efc7 Compare December 20, 2023 12:34
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
Converts the board to hwmv2

Signed-off-by: Jamie McCrae <[email protected]>
@tejlmand tejlmand merged this pull request into tejlmand:nrf52_adopt_soc_scheme_v2 Dec 20, 2023
2 of 3 checks passed
tejlmand pushed a commit that referenced this pull request Oct 30, 2024
hci_packet_complete(buf, buf_size) should check whether buf_size is
enough.
For instance, hci_packet_complete can receive buf with buf_size 1,
leading to the buffer overflow in cmd->param_len, which is buf[3].
This can happen when rx_thread() receives two frames in 512 bytes
and the first frame size is 511. Then, rx_thread() will call
hci_packet_complete() with 1.

==5==ERROR: AddressSanitizer: global-buffer-overflow on address
0x000000ad81c2 at pc 0x0000005279b3 bp 0x7fffe74f5b70 sp 0x7fffe74f5b68

READ of size 2 at 0x000000ad81c2 thread T6
    #0 0x5279b2  (/root/zephyr.exe+0x5279b2)
    #1 0x4d697d  (/root/zephyr.exe+0x4d697d)
    #2 0x7ffff60e5daa  (/lib/x86_64-linux-gnu/libc.so.6+0x89daa)
(BuildId: 2e01923fea4ad9f7fa50fe24e0f3385a45a6cd1c)

0x000000ad81c2 is located 2 bytes to the right of global variable
'rx_thread.frame' defined in 'zephyr/drivers/bluetooth/hci/userchan.c'
(0xad7fc0) of size 512
SUMMARY: AddressSanitizer: global-buffer-overflow
(/root/zephyr.exe+0x5279b2)
Thread T6 created by T2 here:
    #0 0x48c17c  (/root/zephyr.exe+0x48c17c)
    #1 0x530192  (/root/zephyr.exe+0x530192)
    #2 0x4dcc22  (/root/zephyr.exe+0x4dcc22)

Thread T2 created by T1 here:
    #0 0x48c17c  (/root/zephyr.exe+0x48c17c)
    #1 0x530192  (/root/zephyr.exe+0x530192)
    #2 0x4dcc22  (/root/zephyr.exe+0x4dcc22)

Thread T1 created by T0 here:
    #0 0x48c17c  (/root/zephyr.exe+0x48c17c)
    #1 0x52f36c  (/root/zephyr.exe+0x52f36c)
    #2 0x5371dc  (/root/zephyr.exe+0x5371dc)
    #3 0x5312a6  (/root/zephyr.exe+0x5312a6)
    #4 0x52ed7b  (/root/zephyr.exe+0x52ed7b)
    #5 0x52eddd  (/root/zephyr.exe+0x52eddd)
    #6 0x7ffff6083c89  (/lib/x86_64-linux-gnu/libc.so.6+0x27c89)
(BuildId: 2e01923fea4ad9f7fa50fe24e0f3385a45a6cd1c)

==5==ABORTING

Signed-off-by: Sungwoo Kim <[email protected]>
@nordicjm nordicjm deleted the nrf52_adopt_soc_scheme_v2 branch January 27, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants