Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: west_commands: run: Add priority to run once config #7

Conversation

nordicjm
Copy link

@nordicjm nordicjm commented Jul 1, 2024

Adds an optional priority parameter to the flash runner run once configuration which allows for deciding upon which file should ultimately be used

scripts/schemas/board-schema.yml Outdated Show resolved Hide resolved
scripts/west_commands/run_common.py Outdated Show resolved Hide resolved
scripts/west_commands/run_common.py Outdated Show resolved Hide resolved
scripts/west_commands/run_common.py Outdated Show resolved Hide resolved
scripts/west_commands/run_common.py Outdated Show resolved Hide resolved
@tejlmand tejlmand force-pushed the issues/69548_board_extension branch from c528864 to 001b551 Compare July 2, 2024 09:56
@nordicjm nordicjm force-pushed the socboardpriority branch 2 times, most recently from fdf2c61 to db11293 Compare July 8, 2024 07:52
@nordicjm nordicjm requested a review from 57300 July 8, 2024 07:53
57300

This comment was marked as resolved.

@nordicjm nordicjm force-pushed the socboardpriority branch from db11293 to 98b8be5 Compare July 8, 2024 10:54
@nordicjm
Copy link
Author

nordicjm commented Jul 8, 2024

Have removed the check, it would no longer be possible to do it since one repo might have the full flash run once config and the repos that a user has might not have those qualifiers, have reduced it to just do a soc name check but this might also need to be removed in future

@nordicjm nordicjm requested a review from 57300 July 8, 2024 12:27
@57300
Copy link

57300 commented Jul 8, 2024

Have removed the check, it would no longer be possible to do it since one repo might have the full flash run once config and the repos that a user has might not have those qualifiers, have reduced it to just do a soc name check but this might also need to be removed in future

Fine by me 👍 Sadly, that wasn't enough to get rid of the error, but I found another fix. There's a related bug which I decided to fix upstream first: zephyrproject-rtos#75601

@57300 57300 force-pushed the issues/69548_board_extension branch from 001b551 to 04dda37 Compare July 11, 2024 08:40
Copy link

@57300 57300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase

@nordicjm nordicjm closed this Jul 12, 2024
@nordicjm nordicjm deleted the socboardpriority branch January 27, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants