Add Kubectl sample, porting from version "v1alpha1" #278
Conversation
tekton-robot
added
the
size/L
|
/assign @vdemeester |
kubectl/kubectl-deploy.yaml
Outdated
| description: Kubectl wrapper image | ||
| steps: | ||
| - name: kubeconfig | ||
| image: $(inputs.params.image) |
There was a problem hiding this comment.
This needs to a $(params.image) instead 😉
There was a problem hiding this comment.
oh, my mistake, thanks 👍
kubectl/kubectl-deploy.yaml
Outdated
| - name: kubeconfig | ||
| image: $(inputs.params.image) | ||
| script: | | ||
| echo "$(inputs.params.manifest)" > /tmp/resource.yaml |
Use a image with `kubectl` installed, we can setup `step` of `task` in tekton to create arbitrary rsource of kubernates.
vincent-pli
force-pushed
the
add-kubectl-sample
branch
from
d0db9ea to
59c7854
Compare
|
/test pull-tekton-catalog-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| apiVersion: rbac.authorization.k8s.io/v1beta1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: default-admin |
There was a problem hiding this comment.
This seems like dangerous default behavior to recommend to users.
This grants the default SA (which runs every Pod in the cluster unless otherwise specified), complete cluster-admin access.
Can we either:
- Make it clearer to users that this is only intended forr insecure/non-critical use cases, and should be modified after installation to match the user's use case and needs, and/or
- Provide a more scoped-down role binding initially, which users can add to as they need?
There was a problem hiding this comment.
@imjasonh
Thanks for the comments, it's make sense, I will work for a pr for it.
Fix issue: #233 , Porting from
v1alpha1Use a image with
kubectlinstalled, we can setupstepoftaskin tekton to create arbitrary rsource of kubernates.Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.