Update e2e scipts according to new structure #421

piyush-garg · 2020-07-16T06:46:17Z

This will update the e2e scripts to run tests according to
new catalog structure after reorg

Fix git batch merge tests

Fix git clone tests

Fix git cli tests

Remove git-rebase tests as they are not of rebase

Fix golnag build tests

Fix golang-test tests

Fix golangci-lint tests

Fix helm-upgrade-from-repo tests

Fix helm-upgrade-from-source tests

Update skopeo task for tls-verify flag param
This will fix skopeo tasks to have param for tls-verify flag
and update tests accordingly

Skip cloudevent task as it is failing

Fix warning for yaml.Load function

Fix upload-pypi pre-apply-task script

Remove python pypi upload test

Fix #420

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes docs (if user facing)
Commit messages follow commit message best practices
Yaml file complies with yamllint rules.
Complies with Catalog Orgainization TEP, see example. Note An issue has been filed to automate this validation
- File path follows <kind>/<name>/<version>/name.yaml
- Has README.md at <kind>/<name>/<version>/README.md
- Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource
- Has mandatory metadata.annotations tekton.dev/pipelines.minVersion
- mandatory spec.description follows the convention
```
  ```
  
    spec:
      description: >-
        one line summary of the resource
  
        Paragraph(s) to describe the resource.
  ```
```

See the contribution guide
for more details.

This will update the e2e scripts to run tests according to new catalog structure after reorg Fix tektoncd#420

This will fix skopeo tasks to have param for tls-verify flag and update tests accordingly

vdemeester

For future reviewers, the deletion of some tests are because those task are splitted, and thus the tests that were grouped together are now splitted (but they were all still in each files).

/lgtm

vdemeester · 2020-07-16T13:49:38Z

test/e2e-tests.sh

@@ -46,12 +46,12 @@ TEST_YAML_IGNORES=${TEST_YAML_IGNORES:-""}

 # Allow ignoring some yaml tests, space separated, should be the basename of the
 # test for example "s2i"
-TEST_TASKRUN_IGNORES=${TEST_TASKRUN_IGNORES:-""}
+TEST_TASKRUN_IGNORES=${TEST_TASKRUN_IGNORES:-"cloudevent"}


Should we had a comment about this one ? (aka depend on ko, should use a released image in there — we should also create an issue about it)

I am creating an issue for this and also let @iancoffey know :D

I think he is already working, I see a PR #396

Created issue #422

piyush-garg · 2020-07-16T15:03:05Z

/retest

Remove the test as the python pypi upload test is not working on the CI

vinamra28

/lgtm

vdemeester

/meow

tekton-robot · 2020-07-16T17:34:32Z

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2020-07-16T17:34:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from briandealwis, fhopfensperger, imjasonh, khrm, loosebazooka, simonjjones and vdemeester July 16, 2020 06:46

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 16, 2020

piyush-garg force-pushed the fix_ci_tests branch from b3bb1ae to 3bffa60 Compare July 16, 2020 07:14

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2020

piyush-garg force-pushed the fix_ci_tests branch 2 times, most recently from 281639a to 7a064a7 Compare July 16, 2020 08:42

piyush-garg added 10 commits July 16, 2020 17:36

Update e2e scipts according to new structure

830c5b1

This will update the e2e scripts to run tests according to new catalog structure after reorg Fix tektoncd#420

Fix git batch merge tests

a60a054

Fix git clone tests

102260a

Fix git cli tests

4d4aa89

Remove git-rebase tests as they are not of rebase

c1ff952

Fix golnag build tests

c6911d1

Fix golang-test tests

b4909c8

Fix golangci-lint tests

1e48c55

Fix helm-upgrade-from-repo tests

9c03ed9

Fix helm-upgrade-from-source tests

9d0664f

piyush-garg force-pushed the fix_ci_tests branch from 7a064a7 to ee1fe52 Compare July 16, 2020 12:14

piyush-garg added 2 commits July 16, 2020 17:47

Update skopeo task for tls-verify flag param

9a520d6

This will fix skopeo tasks to have param for tls-verify flag and update tests accordingly

Skip cloudevent task as it is failing

a4a0621

piyush-garg force-pushed the fix_ci_tests branch from ee1fe52 to a4a0621 Compare July 16, 2020 12:19

piyush-garg added 2 commits July 16, 2020 18:22

Fix warning for yaml.Load function

78b99a6

Fix upload-pypi pre-applt-task script

6e3d28b

vdemeester reviewed Jul 16, 2020

View reviewed changes

tekton-robot assigned vdemeester Jul 16, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020

PuneetPunamiya mentioned this pull request Jul 16, 2020

Create Docker Build task with sidecar in catalog #409

Merged

3 tasks

Remove python pypi upload test

075e9bf

Remove the test as the python pypi upload test is not working on the CI

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020

piyush-garg mentioned this pull request Jul 16, 2020

Cloudevent test not working #422

Closed

PuneetPunamiya mentioned this pull request Jul 16, 2020

Modifies the path in pre-apply-task-hook.sh file in tests directory #419

Closed

9 tasks

vinamra28 approved these changes Jul 16, 2020

View reviewed changes

tekton-robot assigned vinamra28 Jul 16, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020

vdemeester approved these changes Jul 16, 2020

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020

tekton-robot merged commit 3068d43 into tektoncd:master Jul 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update e2e scipts according to new structure #421

Update e2e scipts according to new structure #421

piyush-garg commented Jul 16, 2020 •

edited

Loading

vdemeester left a comment

vdemeester Jul 16, 2020

piyush-garg Jul 16, 2020

piyush-garg Jul 16, 2020

piyush-garg commented Jul 16, 2020

vinamra28 left a comment

vdemeester left a comment

tekton-robot commented Jul 16, 2020

tekton-robot commented Jul 16, 2020

Update e2e scipts according to new structure #421

Update e2e scipts according to new structure #421

Conversation

piyush-garg commented Jul 16, 2020 • edited Loading

Submitter Checklist

vdemeester left a comment

Choose a reason for hiding this comment

vdemeester Jul 16, 2020

Choose a reason for hiding this comment

piyush-garg Jul 16, 2020

Choose a reason for hiding this comment

piyush-garg Jul 16, 2020

Choose a reason for hiding this comment

piyush-garg commented Jul 16, 2020

vinamra28 left a comment

Choose a reason for hiding this comment

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Jul 16, 2020

tekton-robot commented Jul 16, 2020

piyush-garg commented Jul 16, 2020 •

edited

Loading