-
Notifications
You must be signed in to change notification settings - Fork 255
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove hardcoded golangci-lint and go version
This will remove hardcoded versions of golangci-lint and go in Makefile and release pipeline, instead detect them from go.mod files This will eliminate the need to update them during release and also CI will run the latest golangci-lint version
- Loading branch information
1 parent
f6d3776
commit 8dd3404
Showing
3 changed files
with
14 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,9 @@ CATALOG_TASKS="lint build test" | |
|
||
BINARIES="kubectl jq tkn git" | ||
|
||
GOLANGCI_VERSION="$(cat tools/go.mod | grep golangci-lint | awk '{ print $3 }')" | ||
GO_VERSION="$(cat go.mod | grep "go" | awk 'NR==1{ print $2 }')" | ||
|
||
set -e | ||
|
||
for b in ${BINARIES};do | ||
|
@@ -147,6 +150,8 @@ URL=$(git remote get-url "${PUSH_REMOTE}" | sed 's,[email protected]:,https://githu | |
tkn -n ${TARGET_NAMESPACE} pipeline start cli-release-pipeline \ | ||
-p revision="${RELEASE_VERSION}" \ | ||
-p url="${URL}" \ | ||
-p golangci-lint-version="${GOLANGCI_VERSION}" \ | ||
-p go-version="${GO_VERSION}" \ | ||
-w name=shared-workspace,volumeClaimTemplateFile=./tekton/volume-claim-template.yml | ||
|
||
tkn -n ${TARGET_NAMESPACE} pipeline logs cli-release-pipeline -f --last |