Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the misspell linter, and fix some misspellings. #1075

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jul 18, 2020

Changes

Just a few that look like copy/paste mistakes.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

Just a few that look like copy/paste mistakes.
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 18, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2020
@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-build-tests

1 similar comment
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 19, 2020

/test pull-tekton-cli-build-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@chmouel
Copy link
Member

chmouel commented Jul 20, 2020

/lgtm

@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 20, 2020

/test pull-tekton-cli-build-tests

Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to wait on build test fix.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@danielhelfand
Copy link
Member

/test pull-tekton-cli-build-tests

@tekton-robot tekton-robot merged commit 6d1cfc6 into tektoncd:master Jul 20, 2020
@danielhelfand danielhelfand mentioned this pull request Jul 20, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants