Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Results in the output of ClusterTask describe command #1105

Merged

Conversation

vinamra28
Copy link
Member

Changes

The results declared in the clustertask will be displayed in the output of clustertask describe command. When we will do tkn ct desc <ctname> result name and description will be displayed in the output

Closes #1102

Signed-off-by: vinamra28 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Display results in the output of clustertask describe command

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 4, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 4, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow
/cc @danielhelfand @pradeepitm12 @piyush-garg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2020
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changes for the unit test. Otherwise lgtm.

pkg/cmd/clustertask/describe_test.go Outdated Show resolved Hide resolved
pkg/cmd/clustertask/describe_test.go Outdated Show resolved Hide resolved
pkg/cmd/clustertask/describe_test.go Outdated Show resolved Hide resolved
The results declared in the clustertask will be displayed in the output of clustertask describe command. When we will do `tkn ct desc <ctname>` result name and description will be displayed in the output

Signed-off-by: vinamra28 <[email protected]>
@vinamra28 vinamra28 force-pushed the vinamra28/display-result-ct-describe branch from 665ed30 to 9127b02 Compare August 5, 2020 04:45
@vinamra28 vinamra28 requested a review from danielhelfand August 5, 2020 04:48
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@tekton-robot tekton-robot merged commit cf3296f into tektoncd:master Aug 5, 2020
@vinamra28 vinamra28 deleted the vinamra28/display-result-ct-describe branch August 6, 2020 04:12
danielhelfand added a commit that referenced this pull request Aug 27, 2020
#1084 | [Pradeep Kumar] update version in readme | 2020/07/24-16:56
#1044 | [pthangad] Organize e2e | 2020/07/24-21:25
#1076 | [chetan-rns] Display results in task/taskrun describe command | 2020/07/29-05:54
#1051 | [vinamra28] ClusterTask start interactive mode | 2020/07/30-15:51
#1101 | [Daniel Helfand] add new line for No ClusterTasks found output | 2020/08/04-11:02
#1105 | [vinamra28] Display Results in the output of ClusterTask describe command | 2020/08/05-21:43
#1088 | [Daniel Helfand] add ability to specify podtemplate for taskrun/pipelinerun | 2020/08/10-16:24
#1108 | [Daniel Helfand] add triggers installation for e2e tests | 2020/08/12-16:54
#1110 | [Divyansh42] Display results in the output of pipeline/pipelinerun describe command | 2020/08/12-22:29
#1110 | [Divyansh42] Modify e2e test for pipeline | 2020/08/12-22:29
null | [vinamra28] Add --use-param-defaults option for tkn clustertask start | 2020/08/17-14:46
null | [rudeigerc] Fix the display of 0 Value for Timeout with tkn tr/pr describe | 2020/08/17-15:08
null | [Daniel Helfand] add check for timeout status for pipelinerun and taskrun cancel | 2020/08/18-13:43
null | [Vincent Demeester] pkg/suggestions: print help and error out 🏢 | 2020/08/18-15:57
null | [Vincent Demeester] pkg/suggestions: no help on subcommand errors | 2020/08/18-17:27
null | [Pratik Jagrut] Add EventListener's AVAILABLE Status with tkn eventlistener list | 2020/08/18-19:31
null | [Piyush Garg] Bump pipeline dep to v0.15.2 | 2020/08/19-04:43
null | [Piyush Garg] Bump triggers dep to v0.7.0 | 2020/08/19-06:01
null | [Daniel Helfand] consistent error messaging for triggers commands | 2020/08/19-07:13
null | [rudeigerc] Throw error when deleting tr/pr with non-existing task/pipeline | 2020/08/19-07:32
null | [Daniel Helfand] copy over pipelinerun and taskrun spec for --last and use run options | 2020/08/24-06:46
null | [vinamra28] Display Workspaces in the output of ClusterTask describe command | 2020/08/25-15:02
null | [vinamra28] Display Workspaces in the output of Task describe command | 2020/08/25-15:02
null | [vinamra28] Display workspaces in the output of TaskRun describe command | 2020/08/25-15:02
null | [Piyush Garg] Refactor status formatting | 2020/08/25-17:04
null | [Divyansh42] Modify --use-param-defaults flag and add e2e test | 2020/08/26-05:23
null | [Piyush Garg] Refactor taskrun description | 2020/08/26-09:40
null | [vinamra28] Display Workspaces in the output of Pipeline describe command | 2020/08/26-11:15
null | [vinamra28] Display Workspaces in the output of PipelineRun describe command | 2020/08/26-11:15

Signed-off-by: Daniel Helfand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterTask describe: display result
4 participants