Do Not Delete ClusterTask TaskRuns with --task Flag #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
danielhelfand
commented
Oct 29, 2020
| @@ -65,14 +64,3 @@ func FilterByRef(taskruns []v1beta1.TaskRun, kind string) []v1beta1.TaskRun { | |||
| } | |||
| return filtered | |||
| } | |||
|
|
|||
| // this will filter the taskkrun which have reference to Task | |||
There was a problem hiding this comment.
This isn't used anywhere in the CLI, so I removed it. Let me know if there are considerations around it I am not aware of.
There was a problem hiding this comment.
I am also not sure about this.
There was a problem hiding this comment.
/cc @pradeepitm12 Not sure if you are more familiar with this?
piyush-garg
approved these changes
Nov 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/test pull-tekton-cli-build-tests |
1 similar comment
|
/test pull-tekton-cli-build-tests |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
tkn tr deletewith the--taskoption, if a ClusterTask exists with the same name, the ClusterTask's TaskRuns will also be deleted. This is because of TaskRuns for ClusterTasks having thetekton.dev/tasklabel, which will be removed in January 2021.For now, the workaround is to filter the TaskRuns by the TaskRefKind, ignoring the run for the deletion process if its kind is
ClusterTask. A follow up to this pr should be an option added totkn tr deleteto delete TaskRuns associated with a ClusterTask.Submitter Checklist
make checkmake generatedRelease Notes