-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use goreleaser task from tektoncd/catalog #1260
Use goreleaser task from tektoncd/catalog #1260
Conversation
Since `goreleaser` task is now a part of `tektoncd/catalog` so we can use that task from there and remove that task manifest file from here and reference it in script Signed-off-by: vinamra28 <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @chmouel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks 👍🏼🔥
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#1260 | [vinamra28] Use goreleaser task from tektoncd/catalog | 2020/11/18-09:01 #1261 | [Pradeep Kumar] update README to v0.14.0 | 2020/11/18-12:25 #1259 | [Pratik Jagrut] Add --no-headers flag to tkn condition list command | 2020/11/25-12:19 #1257 | [Chmouel Boudjnah] Use debian/VERSION when building debian package | 2020/11/25-12:33 #1254 | [Pratik Jagrut] Add --no-headers flag to tkn triggerbinding list command | 2020/11/25-14:13 #1255 | [Pratik Jagrut] Add --no-headers flag to tkn triggertemplate list command | 2020/11/25-14:13 #1258 | [Pratik Jagrut] Add --no-headers flag to tkn eventlistener list command | 2020/11/25-15:11 #1178 | [Vincent Demeester] Basic execution plugin module 📟 | 2020/12/01-12:25 #1242 | [Daniel Helfand] allow --prefix-name and --timeout to be overrode when using --last or --use options | 2020/12/01-12:25 #1250 | [Sunghoon Kang] Ignore --follow flag when TaskRun or PipelineRun is done | 2020/12/02-15:28 null | [SM43] Bumps Hub CLI Dependency | 2020/12/16-12:32 null | [Matt Moore] Hoist an ActivityTimeout option. | 2020/12/16-18:26 null | [Pradeep Kumar] bump pipeline and triggers dep | 2020/12/17-07:47 null | [Daniel Helfand] remove --check shorthand and add global flags to version cmd | 2020/12/17-08:59 Signed-off-by: Chmouel Boudjnah <[email protected]>
Changes
Since
goreleaser
task is now a part oftektoncd/catalog
so we can use thattask from there and remove that task manifest file from here and reference it in script.
closes #1170
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes