Use python3 binary instead of python or we won't find it #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error when release was : ```[build-rpm] tekton/rpmbuild/build.sh: line 22: python: command not found``` Signed-off-by: Chmouel Boudjnah <[email protected]>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
|
/lgtm |
|
/test pull-tekton-cli-integration-tests-0_10 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
piyush-garg
added a commit
that referenced
this pull request
Feb 9, 2021
#1274 | [Chmouel Boudjnah] Update README to 0.15.0 | 2020/12/17-12:06 #1271 | [Chmouel Boudjnah] Use python3 binary instead of python or we won't find it | 2020/12/17-12:34 #1149 | [Veeresh Aradhya] Fixing clustertask e2e tests | 2020/12/19-07:32 #1149 | [Veeresh Aradhya] Addressing review comments | 2020/12/19-07:32 #1149 | [Veeresh Aradhya] Rebasing and updating code | 2020/12/19-07:32 #1272 | [Chmouel Boudjnah] Debian package: Do not use tkn version as a check | 2020/12/20-03:17 #1276 | [Piyush Garg] Refactor e2e scripts and fix tests | 2020/12/21-15:00 #1268 | [Chmouel Boudjnah] Drop chmouels fork and use latest cobra upstream | 2020/12/23-08:11 #1268 | [Chmouel Boudjnah] Add new completions based on new upstream completion system | 2020/12/23-08:11 #1277 | [Daniel Helfand] fix tkn version with no kubeconfig | 2021/01/05-09:29 null | [Dan Chao] Add support for showing logs for retried taskruns | 2021/01/14-05:19 null | [vinamra28] Support --clustertask Option for tkn tr delete | 2021/01/15-05:43 null | [Rupali] `tkn completion` command will bail out if something else is passed apart from expected args Modified unit test as required | 2021/01/21-17:33 null | [Chmouel Boudjnah] Add information to the README about homebrew on linux | 2021/02/02-14:41 null | [vinamra28] Update TaskRun Tests from Test Builders to Structs | 2021/02/04-12:24 null | [vinamra28] Fix eventlistener manifests as per latest triggers | 2021/02/04-12:24 null | [vinamra28] Update Task Tests from Test Builders to Structs | 2021/02/04-13:36 null | [Piyush Garg] Bump pipeline dep to v0.20.1 | 2021/02/05-06:04 null | [Piyush Garg] Update trigger dep to v0.11.2 | 2021/02/08-09:06 Signed-off-by: Piyush Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error when release was :
[build-rpm] tekton/rpmbuild/build.sh: line 22: python: command not foundChanges
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes