Update TaskRun Tests from Test Builders to Structs #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
size/XXL
|
/lgtm |
pradeepitm12
approved these changes
Feb 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
Migrating unit tests for `tkn taskrun` from test builders to structs. Signed-off-by: vinamra28 <[email protected]>
|
/retest |
vinamra28
force-pushed
the
taskrun-tb-to-structs
branch
from
b5f9e7b to
0dc5e5c
Compare
vinamra28
force-pushed
the
taskrun-tb-to-structs
branch
from
0e8bc13 to
c18a4fb
Compare
In Eventlisterner manifest in the template field the `name` has now changed to `ref` Signed-off-by: vinamra28 <[email protected]>
vinamra28
force-pushed
the
taskrun-tb-to-structs
branch
from
c18a4fb to
0e0b113
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Migrating unit tests for
tkn taskrunfrom test builders to structs.Part of #1145
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes