-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove builders from codebase #1466
Conversation
This will remove builders from codebase and move the remaning part to also structs This also remove the builders written in cli codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 null | [Pradeep Kumar] update goreleaser | 2022/02/01-09:36 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 null | [Pradeep Kumar] update goreleaser | 2022/02/01-09:36 null | [Pradeep Kumar] update goreleaser config | 2022/02/01-11:28 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 null | [Pradeep Kumar] update goreleaser | 2022/02/01-09:36 null | [Pradeep Kumar] update goreleaser config | 2022/02/01-11:28 Signed-off-by: Pradeep Kumar <[email protected]>
#1461 | [Piyush Garg] Update readme with latest v0.21.0 | 2021/10/06-10:58 #1462 | [Daniel Helfand] update chocolatey package for 0.21.0 release | 2021/10/06-16:17 #1457 | [pratap0007] Replace test builders to structs in unit test for `tkn pipeline` | 2021/10/13-09:37 #1464 | [Rick] Correct the license claim in the goreleaser config | 2021/10/15-15:01 #1463 | [pratap0007] Replace test builders to structs in unit test for `tkn pipelinerun` | 2021/10/20-02:17 #1466 | [Piyush Garg] Remove builders from codebase | 2021/10/21-06:44 #1475 | [Vincent Demeester] Update some dependencies to fix vulnerabiliites | 2021/12/15-13:17 #1398 | [Chmouel Boudjnah] Add a pipeline export command | 2022/01/21-09:43 #1479 | [vinamra28] Handle graceful termination of Pipeline | 2022/01/21-12:16 #1486 | [PuneetPunamiya] Adds operator verison in output of `tkn version` command | 2022/01/24-06:08 null | [vinamra28] Show all cancelled taskruns in message section | 2022/01/25-05:41 null | [pratap0007] Skips to ask specifications for optional workspace | 2022/01/26-15:59 null | [Chmouel Boudjnah] Bump go mod version to 1.16 | 2022/01/27-07:09 null | [Pradeep Kumar] bump pipelines to v0.31.0 bump triggers to v0.17.1 bump hub/api to latest bump knative.dev/pkg to latest hub docs update bump pipelines to v.32.0 | 2022/01/27-15:11 null | [vinamra28] Bump Tekton Hub CLI to latest | 2022/01/28-09:01 null | [Zhu Sheng Li] Hide sections with empty results for `describe` command | 2022/01/28-23:54 null | [Piyush Garg] Bump deps | 2022/01/31-07:12 null | [Pradeep Kumar] update golangci-lint version | 2022/01/31-11:26 null | [Pradeep Kumar] update go build and test | 2022/01/31-15:13 null | [Pradeep Kumar] update goreleaser | 2022/02/01-09:36 null | [Pradeep Kumar] update goreleaser config | 2022/02/01-11:28 Signed-off-by: Pradeep Kumar <[email protected]>
This will remove builders from codebase
and move the remaning part to also structs
This also remove the builders written in cli codebase
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes