Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templating to use $(…) instead of ${…} #336

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Update templating to use $(…) instead of ${…} #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tekton/goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,31 +17,31 @@ spec:
resources:
- name: source
type: git
targetPath: src/${inputs.params.package}
targetPath: src/$(inputs.params.package)
steps:
- name: pull
image: goreleaser/goreleaser
workingdir: /workspace/src/${inputs.params.package}
workingdir: /workspace/src/$(inputs.params.package)
command:
- /bin/bash
args:
- -c
- "git status; git fetch -p --all"
- name: release
image: goreleaser/goreleaser
workingdir: /workspace/src/${inputs.params.package}
workingdir: /workspace/src/$(inputs.params.package)
command:
- /bin/bash
args:
- -c
- "goreleaser release ${inputs.params.flags}"
- "goreleaser release $(inputs.params.flags)"
env:
- name: GOPATH
value: /workspace
- name: GITHUB_TOKEN
valueFrom:
secretKeyRef:
# FIXME(vdemeester): this need to be fixed upstream, template should work there
#name: ${inputs.params.github-token-secret}
#name: $(inputs.params.github-token-secret)
name: bot-token-github
key: bot-token
10 changes: 5 additions & 5 deletions tekton/release-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ spec:
name: golangci-lint
params:
- name: package
value: ${params.package}
value: $(params.package)
- name: flags
value: -v
resources:
Expand All @@ -34,7 +34,7 @@ spec:
name: golang-test
params:
- name: package
value: ${params.package}
value: $(params.package)
resources:
inputs:
- name: source
Expand All @@ -45,7 +45,7 @@ spec:
name: golang-build
params:
- name: package
value: ${params.package}
value: $(params.package)
resources:
inputs:
- name: source
Expand All @@ -56,9 +56,9 @@ spec:
name: goreleaser
params:
- name: package
value: ${params.package}
value: $(params.package)
- name: github-token-secret
value: ${params.github-token-secret}
value: $(params.github-token-secret)
resources:
inputs:
- name: source
Expand Down