Add feature to start task #347

piyush-garg · 2019-10-03T06:45:03Z

Changes

This will add the feature of starting
a task or creating a taskrun from cli

Command will be like tkn task start ..

Add -i flag for input resources
Add -o flag for output resources
Add -p flag for param
Add -l flag for labels
Add --last flag for starting on basis of last run
Add -s flag for serviceaccount

Add docs and tests

Refactoring to remove duplicate code

Fix #320

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Regenerate the manpages and docs with make docs and make man if needed.
Run the code checkers with make check
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Feature to start task from cli

piyush-garg · 2019-10-03T06:45:24Z

/work-in-progress

tekton-robot · 2019-10-03T06:47:14Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	91.7%	90.7%	-1.0
pkg/cmd/task/start.go	Do not exist	13.5%
pkg/helper/params/mergeparams.go	Do not exist	100.0%
pkg/helper/pipeline/pipelinelastrun.go	84.6%	92.3%	7.7
pkg/helper/task/tasklastrun.go	Do not exist	92.3%

piyush-garg · 2019-10-03T06:49:07Z

/status in-progress

piyush-garg · 2019-10-03T06:50:39Z

/hold

tekton-robot · 2019-10-04T11:53:49Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	92.0%	91.6%	-0.3
pkg/cmd/task/start.go	Do not exist	95.9%
pkg/helper/params/mergeparams.go	Do not exist	100.0%
pkg/helper/pipeline/pipelinelastrun.go	84.6%	92.3%	7.7
pkg/helper/task/tasklastrun.go	Do not exist	92.3%

piyush-garg · 2019-10-04T11:55:07Z

/hold cancel

tekton-robot · 2019-10-04T15:57:15Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	92.0%	91.0%	-1.0
pkg/cmd/task/start.go	Do not exist	96.2%
pkg/helper/labels/mergelabels.go	Do not exist	100.0%
pkg/helper/params/mergeparams.go	Do not exist	100.0%
pkg/helper/pipeline/pipelinelastrun.go	84.6%	92.3%	7.7
pkg/helper/task/tasklastrun.go	Do not exist	92.3%

piyush-garg · 2019-10-09T13:32:24Z

/cc hrishin

piyush-garg · 2019-10-09T13:32:50Z

/cc pradeepitm12

tekton-robot · 2019-10-10T13:56:51Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	92.0%	91.0%	-1.0
pkg/cmd/task/start.go	Do not exist	96.2%
pkg/helper/labels/mergelabels.go	Do not exist	100.0%
pkg/helper/params/mergeparams.go	Do not exist	100.0%
pkg/helper/pipeline/pipelinelastrun.go	84.6%	92.3%	7.7
pkg/helper/task/tasklastrun.go	Do not exist	92.3%

piyush-garg · 2019-10-10T14:02:08Z

/test pull-tekton-cli-unit-tests

pradeepitm12 · 2019-10-10T14:24:19Z

/test pull-tekton-cli-unit-tests

piyush-garg · 2019-10-10T15:49:36Z

/test pull-tekton-cli-unit-tests

piyush-garg · 2019-10-10T16:03:32Z

/test pull-tekton-cli-unit-tests

tekton-robot · 2019-10-16T08:40:47Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	90.9%	89.7%	-1.2
pkg/cmd/task/start.go	Do not exist	96.2%
pkg/helper/labels/mergelabels.go	Do not exist	100.0%
pkg/helper/params/mergeparams.go	Do not exist	100.0%
pkg/helper/pipeline/pipelinelastrun.go	84.6%	92.3%	7.7
pkg/helper/task/tasklastrun.go	Do not exist	92.3%

This will add the feature of starting a task or creating a taskrun from cli Command will be like `tkn task start ..` Add -i flag for input resources Add -o flag for output resources Add -p flag for param Add -l flag for labels Add --last flag for starting on basis of last run Add -s flag for serviceaccount Add docs and tests Refactoring to remove duplicate code Fix tektoncd#320

tekton-robot · 2019-10-16T10:37:28Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	90.9%	89.7%	-1.2
pkg/cmd/task/start.go	Do not exist	96.2%
pkg/helper/labels/mergelabels.go	Do not exist	100.0%
pkg/helper/params/mergeparams.go	Do not exist	100.0%
pkg/helper/pipeline/pipelinelastrun.go	84.6%	92.3%	7.7
pkg/helper/task/tasklastrun.go	Do not exist	92.3%

piyush-garg · 2019-10-16T10:51:10Z

/test pull-tekton-cli-unit-tests

piyush-garg · 2019-10-16T11:07:11Z

/test pull-tekton-cli-unit-tests

vdemeester

/lgtm
/cc @hrishin @chmouel

vdemeester · 2019-10-17T16:35:02Z

pkg/cmd/pipeline/start.go

@@ -26,6 +26,8 @@ import (
 	"github.com/tektoncd/cli/pkg/cli"
 	"github.com/tektoncd/cli/pkg/cmd/pipelinerun"
 	"github.com/tektoncd/cli/pkg/flags"
+	"github.com/tektoncd/cli/pkg/helper/labels"


nit: I am not a huge fine of the helper package but it's already there, so can be changed in a follow-up anyway 😉

This is required for both, start pipeline and start task so I put this in helper

tekton-robot · 2019-10-18T08:06:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

piyush-garg · 2019-10-18T16:20:01Z

/test pull-tekton-cli-unit-tests

piyush-garg · 2019-10-18T16:43:23Z

/test pull-tekton-cli-unit-tests

piyush-garg · 2019-10-18T17:00:51Z

/test pull-tekton-cli-unit-tests

tekton-robot requested review from chmouel and vdemeester October 3, 2019 06:45

googlebot added the cla: yes label Oct 3, 2019

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 3, 2019

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2019

piyush-garg force-pushed the iss_320 branch from 1c3a005 to 8f9f5a9 Compare October 4, 2019 11:51

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 4, 2019

piyush-garg changed the title ~~Add start task feature~~ Add feature to start task Oct 4, 2019

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2019

piyush-garg force-pushed the iss_320 branch from 8f9f5a9 to 285ba49 Compare October 4, 2019 15:54

tekton-robot requested a review from hrishin October 9, 2019 13:32

tekton-robot requested a review from pradeepitm12 October 9, 2019 13:32

piyush-garg force-pushed the iss_320 branch from 285ba49 to 9534980 Compare October 10, 2019 13:54

piyush-garg force-pushed the iss_320 branch from 9534980 to 627a06b Compare October 16, 2019 08:28

piyush-garg force-pushed the iss_320 branch from 627a06b to fe633af Compare October 16, 2019 10:35

vdemeester reviewed Oct 17, 2019

View reviewed changes

tekton-robot assigned vdemeester Oct 17, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2019

vdemeester mentioned this pull request Oct 18, 2019

Start task and follow logs #368

Closed

vdemeester approved these changes Oct 18, 2019

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2019

tekton-robot merged commit 7426d83 into tektoncd:master Oct 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add feature to start task #347

Add feature to start task #347

piyush-garg commented Oct 3, 2019 •

edited

Loading

piyush-garg commented Oct 3, 2019

tekton-robot commented Oct 3, 2019

piyush-garg commented Oct 3, 2019

piyush-garg commented Oct 3, 2019

tekton-robot commented Oct 4, 2019

piyush-garg commented Oct 4, 2019

tekton-robot commented Oct 4, 2019

piyush-garg commented Oct 9, 2019

piyush-garg commented Oct 9, 2019

tekton-robot commented Oct 10, 2019

piyush-garg commented Oct 10, 2019

pradeepitm12 commented Oct 10, 2019

piyush-garg commented Oct 10, 2019

piyush-garg commented Oct 10, 2019

tekton-robot commented Oct 16, 2019

tekton-robot commented Oct 16, 2019

piyush-garg commented Oct 16, 2019

piyush-garg commented Oct 16, 2019

vdemeester left a comment

vdemeester Oct 17, 2019

piyush-garg Oct 17, 2019

tekton-robot commented Oct 18, 2019

piyush-garg commented Oct 18, 2019

piyush-garg commented Oct 18, 2019

piyush-garg commented Oct 18, 2019

Add feature to start task #347

Add feature to start task #347

Conversation

piyush-garg commented Oct 3, 2019 • edited Loading

Changes

Submitter Checklist

Release Notes

piyush-garg commented Oct 3, 2019

tekton-robot commented Oct 3, 2019

piyush-garg commented Oct 3, 2019

piyush-garg commented Oct 3, 2019

tekton-robot commented Oct 4, 2019

piyush-garg commented Oct 4, 2019

tekton-robot commented Oct 4, 2019

piyush-garg commented Oct 9, 2019

piyush-garg commented Oct 9, 2019

tekton-robot commented Oct 10, 2019

piyush-garg commented Oct 10, 2019

pradeepitm12 commented Oct 10, 2019

piyush-garg commented Oct 10, 2019

piyush-garg commented Oct 10, 2019

/test pull-tekton-cli-unit-tests

tekton-robot commented Oct 16, 2019

tekton-robot commented Oct 16, 2019

piyush-garg commented Oct 16, 2019

piyush-garg commented Oct 16, 2019

vdemeester left a comment

Choose a reason for hiding this comment

vdemeester Oct 17, 2019

Choose a reason for hiding this comment

piyush-garg Oct 17, 2019

Choose a reason for hiding this comment

tekton-robot commented Oct 18, 2019

piyush-garg commented Oct 18, 2019

piyush-garg commented Oct 18, 2019

piyush-garg commented Oct 18, 2019

piyush-garg commented Oct 3, 2019 •

edited

Loading