Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring resource list #351

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Oct 9, 2019

This will refactor the listing of pipeline resource
in tkn res list and tkn task describe taskname
and tkn pipeline describe pipelinename commands.

Now it will show the resources sorted by type and
then further sorted by name

Refactor tests accordingly

Fixes #148

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelineresource/list.go 85.0% 87.0% 2.0
pkg/cmd/task/describe.go 89.7% 92.5% 2.8

This will refactor the listing of pipeline resource
in `tkn res list` and `tkn task describe taskname`
and `tkn pipeline describe pipelinename` commands.

Now it will show the resources sorted by type and
then further sorted by name

Refactor tests accordingly
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/describe.go 87.5% 90.9% 3.4
pkg/cmd/pipelineresource/list.go 85.0% 87.0% 2.0
pkg/cmd/task/describe.go 89.7% 92.5% 2.8

@chmouel
Copy link
Member

chmouel commented Oct 10, 2019

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2019
@tekton-robot tekton-robot merged commit 68396ab into tektoncd:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should pipelineresource be grouped in the list
4 participants