Use *** instead of plain text for password #363
Conversation
tekton-robot
added
the
size/S
|
that shuld be easy to test, isnt it ? |
tekton-robot
added
do-not-merge/hold
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
@chmouel |
|
/test pull-tekton-cli-unit-tests |
pkg/cmd/pipelineresource/create.go
Outdated
| @@ -284,10 +284,19 @@ func (res *resource) askClusterParams() error { | |||
| res.pipelineResource.Spec.Params = append(res.pipelineResource.Spec.Params, usernameParam) | |||
| } | |||
|
|
|||
| insecureParam, err := askParam("insecure", res.askOpts) | |||
| insecureAns, err := askToSelect("Is the cluster secure?", []string{"true", "false"}, res.askOpts) | |||
There was a problem hiding this comment.
what is this about ?
and if we are asking for a confirmation can we use the standard yes no?
There was a problem hiding this comment.
this comes from comments we get in yesterday's demo call,
Yes, it makes sense to create another PR for this.
I will change it to yes/no and map it to true/false internally.
Thanks for the review.
pipeline resource yamls stores password as plain text but with cli it makes sense to show the password as ** on console instead of plain text this shows ** for the value of password but writes as plain text in the resource struct Signed-off-by: Pradeep Kumar <[email protected]>
tekton-robot
added
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pipeline resource yamls stores password as plain text
but with cli it makes sense to show the password as ** on
console instead of plain text
this shows ** for the value of password but writes as plain
text in the resource struct
Signed-off-by: Pradeep Kumar [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docsandmake manif needed.make checkSee the contribution guide
for more details.
Release Notes