Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate windows binary release files as zip file #398

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Generate windows binary release files as zip file #398

merged 1 commit into from
Oct 25, 2019

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Oct 24, 2019 •
edited
Loading

Closes #397

Release ChangeLog:

Windows binary are now provided as zip file

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2019
@chmouel chmouel added this to the 0.5.0 🐱 milestone Oct 24, 2019
vdemeester
vdemeester approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@chmouel
Copy link
Member Author

chmouel commented Oct 24, 2019

/retest

@vdemeester
Copy link
Member

/test pull-tekton-cli-build-tests

@vdemeester
Copy link
Member 

I1024 15:19:59.141] github.com/tektoncd/cli/pkg/test imports
I1024 15:19:59.141]     github.com/tektoncd/pipeline/test imports
I1024 15:19:59.142]     knative.dev/pkg/controller imports
I1024 15:19:59.142]     knative.dev/pkg/metrics imports
I1024 15:19:59.142]     contrib.go.opencensus.io/exporter/stackdriver tested by
I1024 15:19:59.142]     contrib.go.opencensus.io/exporter/stackdriver.test imports
I1024 15:19:59.142]     go.opencensus.io/exemplar: module go.opencensus.io@latest (v0.22.1) found, but does not contain package go.opencensus.io/exemplar

Hum 🤔 That is new…

@chmouel
Copy link
Member Author

chmouel commented Oct 25, 2019

/retest

1 similar comment
@chmouel
Copy link
Member Author

chmouel commented Oct 25, 2019

/retest

@tekton-robot tekton-robot merged commit 64532a2 into tektoncd:master Oct 25, 2019
@chmouel chmouel deleted the issue-397-windows-binary-sho branch June 27, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
0.5.0 🐱
Development

Successfully merging this pull request may close these issues.

Windows binary should be generate zip file
4 participants
@chmouel @tekton-robot @vdemeester @googlebot