Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plumbing to latest changes 🔗 #462

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

vdemeester
Copy link
Member

Changes

This adds yaml_build_tests check.

Signed-off-by: Vincent Demeester [email protected]

/cc @chmouel

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

@tekton-robot tekton-robot requested a review from chmouel November 14, 2019 09:05
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2019
@chmouel
Copy link
Member

chmouel commented Nov 14, 2019

let enter the dragons

/lgtm
/approve
/meow

Thanks 🙇🏽‍♂️😻

@tekton-robot
Copy link
Contributor

@chmouel: cat image

In response to this:

let enter the dragons

/lgtm
/approve
/meow

Thanks 🙇🏽‍♂️😻

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 14, 2019
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
This adds `yaml_build_tests` check.

Signed-off-by: Vincent Demeester <[email protected]>
@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-unit-tests

Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit dd25a65 into tektoncd:master Nov 14, 2019
@vdemeester vdemeester deleted the bump-plubming branch November 14, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants