Improve message for creating new resource in start #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will improve the message for creating new resource in interactive pipeline start as it is not showing for which resource of pipeline you need to create a pipelineresource Fix tektoncd#475
tekton-robot
added
the
size/XS
danielhelfand
approved these changes
Nov 30, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/test pull-tekton-cli-unit-tests |
danielhelfand
added a commit
that referenced
this pull request
Dec 11, 2019
#478 | [Daniel Helfand] adding timeout to tkn task start | 2019/11/26-10:59 #469 | [Daniel Helfand] include taskrun failure message in logs | 2019/11/26-11:54 #432 | [16yuki0702] Related issues are #263 #414 | 2019/11/27-03:16 #481 | [Vibhav Bobade] Feature: Set current kubernetes context | 2019/11/27-22:06 #481 | [Vibhav Bobade] Updated docs/man with new feature for setting kubecontext | 2019/11/27-22:06 #484 | [Chmouel Boudjnah] Add a step into the RELEASE_PROCESS documentation | 2019/11/29-08:42 #483 | [Piyush Garg] Fix failure in case of array param having single value | 2019/11/29-08:57 #485 | [Daniel Helfand] minor edits to RELEASE_PROCESS.md | 2019/11/29-09:26 #487 | [Daniel Helfand] 0.5.1 version in README | 2019/12/01-11:02 #486 | [Piyush Garg] Improve message for creating new resource in start | 2019/12/02-01:05 null | [Chmouel Boudjnah] Use serviceAccountName instead of serviceAccount | 2019/12/03-10:11 null | [Daniel Helfand] remove extra space from tr not found error | 2019/12/03-10:42 null | [16yuki0702] Making taskrun logs interactive. | 2019/12/04-09:25 null | [16yuki0702] Correcting interactive menu string and testing error messages | 2019/12/04-09:25 null | [Vincent Demeester] Add golint to the linter 🚐 | 2019/12/04-10:16 null | [Vincent Demeester] Fix golint errors 👨🍳 | 2019/12/04-10:16 null | [Piyush Garg] Bump tektoncd/pipeline to version 0.9.0 | 2019/12/04-15:12 null | [Piyush Garg] Fixes to support tekton pipeline 0.9.0 | 2019/12/04-15:12 null | [Daniel Helfand] add pipeline create command | 2019/12/05-09:10 null | [Daniel Helfand] add task create command | 2019/12/05-10:05 null | [Piyush Garg] Bump to tektoncd/pipeline 0.9.1 | 2019/12/09-05:09 null | [Daniel Helfand] add namespace check to pipeline and task create commands | 2019/12/09-08:03 null | [Daniel Helfand] add resource create -f option | 2019/12/09-11:56 null | [Chmouel Boudjnah] Add NFPM (deb/rpm) release to goreleaser | 2019/12/10-13:15 null | [Piyush Garg] Fix input params are not respected | 2019/12/11-06:02 null | [Chmouel Boudjnah] Add debian package | 2019/12/11-09:25 Signed-off-by: Daniel Helfand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the message for creating new resource in
interactive pipeline start as it is not showing for which resource
of pipeline you need to create a pipelineresource
Fix #475
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docsandmake manif needed.make checkSee the contribution guide
for more details.