tkn pipeline create Command #492

danielhelfand · 2019-12-03T05:08:37Z

This pull request adds a tkn pipeline create command that helps address #192. It draws a lot of its design from #265 with some fixes from the original proposal.

This implementation only supports YAML. It can create a pipeline via a pipeline defined in a local or remote file.

Usage:

Local file:
tkn pipeline create -f localfile.yaml

Remote file:
tkn pipeline create -f https://foo.com/remotefile.yaml

Co-Authored-By: Jie Shen [email protected]

Submitter Checklist

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Regenerate the manpages and docs with make docs and make man if needed.
Run the code checkers with make check
Commit messages follow commit message best practices

Release Notes

Adding tkn pipeline create command to create pipelines

googlebot · 2019-12-03T05:08:40Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tekton-robot · 2019-12-03T05:11:11Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	80.6%

danielhelfand · 2019-12-03T05:20:25Z

@gavinfish Thanks for a lot of your work in helping put this pr together. I would like to give you co-authorship of this pr. Would you be willing to sign the CLA?

tekton-robot · 2019-12-03T05:49:08Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	80.6%

danielhelfand · 2019-12-03T05:54:26Z

pkg/cmd/pipeline/create.go

+		},
+	}
+	f.AddFlags(c)
+	c.Flags().StringVarP(&opts.from, "from", "f", "", "local or remote filename to use to create the pipeline")


Question here is whether to include option or just accept arg at command line.

I think this is fine, no issue

tekton-robot · 2019-12-03T05:54:30Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	80.6%

tekton-robot · 2019-12-03T05:58:37Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	80.6%

tekton-robot · 2019-12-03T06:18:21Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	80.6%

danielhelfand · 2019-12-03T13:49:13Z

/test pull-tekton-cli-unit-tests
/test pull-tekton-cli-integration-tests

danielhelfand · 2019-12-03T14:06:51Z

/test pull-tekton-cli-integration-tests

danielhelfand · 2019-12-03T14:08:45Z

/test pull-tekton-cli-unit-tests

danielhelfand · 2019-12-03T16:23:22Z

/retest

googlebot · 2019-12-03T19:37:03Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

tekton-robot · 2019-12-03T19:49:16Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	80.6%

piyush-garg

/lgtm

pkg/cmd/pipeline/create_test.go

pkg/cmd/pipeline/testdata/pipeline.yaml

pkg/cmd/pipeline/testdata/pipelinerun.yaml

pkg/helper/file/testdata/task.yaml

danielhelfand · 2019-12-04T12:19:47Z

@piyush-garg Thanks! Added licenses.

tekton-robot · 2019-12-04T12:30:48Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	80.6%

tekton-robot · 2019-12-04T19:17:34Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

tekton-robot · 2019-12-04T19:33:50Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

tekton-robot · 2019-12-04T20:31:31Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

tekton-robot · 2019-12-04T21:08:11Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

tekton-robot · 2019-12-04T21:27:31Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

tekton-robot · 2019-12-04T22:27:34Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

tekton-robot · 2019-12-05T02:56:05Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

tekton-robot · 2019-12-05T03:19:51Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

tekton-robot · 2019-12-05T03:40:59Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

vdemeester

/lgtm

tekton-robot · 2019-12-05T14:12:53Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/create.go	Do not exist	93.3%
pkg/helper/file/file.go	Do not exist	51.6%

vdemeester

/lgtm

tekton-robot · 2019-12-05T15:09:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

change master to main for upstream

googlebot added the cla: no label Dec 3, 2019

tekton-robot requested review from chmouel and vdemeester December 3, 2019 05:08

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 3, 2019

danielhelfand commented Dec 3, 2019

View reviewed changes

googlebot added cla: yes and removed cla: no labels Dec 3, 2019

piyush-garg approved these changes Dec 4, 2019

View reviewed changes

tekton-robot assigned piyush-garg Dec 4, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019

piyush-garg reviewed Dec 4, 2019

View reviewed changes

pkg/cmd/pipeline/create_test.go Show resolved Hide resolved

piyush-garg reviewed Dec 4, 2019

View reviewed changes

pkg/cmd/pipeline/testdata/pipeline.yaml Show resolved Hide resolved

piyush-garg reviewed Dec 4, 2019

View reviewed changes

pkg/cmd/pipeline/testdata/pipelinerun.yaml Show resolved Hide resolved

piyush-garg reviewed Dec 4, 2019

View reviewed changes

pkg/helper/file/testdata/task.yaml Show resolved Hide resolved

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019

vdemeester approved these changes Dec 5, 2019

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019

add pipeline create command

2d80b17

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019

vdemeester approved these changes Dec 5, 2019

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019

danielhelfand mentioned this pull request Dec 5, 2019

Add tkn task create #502

Merged

5 tasks

tekton-robot merged commit 8aae696 into tektoncd:master Dec 5, 2019

This was referenced Dec 6, 2019

Add tkn resource create -f Option #504

Merged

Add Namespace Check to Pipeline and Task Create Commands #507

Merged

pradeepitm12 pushed a commit to pradeepitm12/cli that referenced this pull request Jun 30, 2021

Merge pull request tektoncd#492 from pradeepitm12/master-main

44c862a

change master to main for upstream

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tkn pipeline create Command #492

tkn pipeline create Command #492

danielhelfand commented Dec 3, 2019

googlebot commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

danielhelfand commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

danielhelfand Dec 3, 2019

piyush-garg Dec 4, 2019

tekton-robot commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

danielhelfand commented Dec 3, 2019

danielhelfand commented Dec 3, 2019 •

edited

Loading

danielhelfand commented Dec 3, 2019

danielhelfand commented Dec 3, 2019

googlebot commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

piyush-garg left a comment

danielhelfand commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 5, 2019

tekton-robot commented Dec 5, 2019

tekton-robot commented Dec 5, 2019

vdemeester left a comment

tekton-robot commented Dec 5, 2019

vdemeester left a comment

tekton-robot commented Dec 5, 2019

tkn pipeline create Command #492

tkn pipeline create Command #492

Conversation

danielhelfand commented Dec 3, 2019

Submitter Checklist

Release Notes

googlebot commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

danielhelfand commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

danielhelfand Dec 3, 2019

Choose a reason for hiding this comment

piyush-garg Dec 4, 2019

Choose a reason for hiding this comment

tekton-robot commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

danielhelfand commented Dec 3, 2019

danielhelfand commented Dec 3, 2019 • edited Loading

danielhelfand commented Dec 3, 2019

danielhelfand commented Dec 3, 2019

googlebot commented Dec 3, 2019

tekton-robot commented Dec 3, 2019

piyush-garg left a comment

Choose a reason for hiding this comment

danielhelfand commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 4, 2019

tekton-robot commented Dec 5, 2019

tekton-robot commented Dec 5, 2019

tekton-robot commented Dec 5, 2019

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Dec 5, 2019

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Dec 5, 2019

danielhelfand commented Dec 3, 2019 •

edited

Loading