-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all auth clients #628
Add all auth clients #628
Conversation
Let me know if that works for you @tomhau01 thanks! |
acace66
to
a9d3024
Compare
Is there a binary somewhere I could test? |
@tomhau01 there is not on CI but i can provide you one, is that for osx, linux? |
Just saw that you are using OSX so here is a binary : |
a9d3024
to
d175f22
Compare
Gave your binary a go, and it works. That was a very speedy fix, kudos! |
d175f22
to
9423d4a
Compare
Build error is:
|
No chance to get this into 0.7.0? |
9423d4a
to
08ae64f
Compare
@tomhau01 Sorry about this, I had some issues unfortunately with an unrelated (to azure) auth, let me try to rework this to only include the azure client. I think it’s a bit late for 0.7.0 unfortunately as @piyush-garg is just finishing the release |
Okay, thanks for looking into it. |
Signed-off-by: Chmouel Boudjnah <[email protected]>
Signed-off-by: Chmouel Boudjnah <[email protected]>
08ae64f
to
f9f2fdc
Compare
@tomhau01 Hey Tom, i have fixed the CI issues and we are going to be able to roll this in for 0.7.1 (0.7.0 had some issues), out of sanity check can you test this binary to make sure everything is fine? https://osinstall.chmouel.com/tmp/tkn thansk! |
Works fine! |
@tomhau01 cool thanks you, @piyush-garg that's ready for merg for 0.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks 🙇♂️
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#628 | [Chmouel Boudjnah] Add all client-go dependency | 2020/02/04-03:49 #628 | [Chmouel Boudjnah] Regenerate codegen and vendor for the client-go auth deps | 2020/02/04-03:49 #673 | [Piyush Garg] Update gotest.tools to use our fork | 2020/02/04-04:27 Signed-off-by: Piyush Garg <[email protected]>
Add all auth client-go clients as documented here https://git.io/JvL6r
Closes #627
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docs
andmake man
if needed.make check
See the contribution guide
for more details.
Release Notes