Makefile fixes #687
Makefile fixes #687
Conversation
tekton-robot
added
the
size/XS
Some makefile fixes: * Include `lint-yaml` target when doing `make lint` * Add `generate` target that would includes all the generation targets (ie man docs/golden) * Fix make fmt, $() is evaluated in makefile, need to use backquote for subshell exansion
chmouel
force-pushed
the
make-generate
branch
from
d600a6d to
7a274ce
Compare
Signed-off-by: Chmouel Boudjnah <[email protected]>
tekton-robot
added
size/S
| @@ -80,13 +80,16 @@ man: bin/docs ## update manpages | |||
| @echo "Update generated manpages" | |||
| @./bin/docs --target=./docs/man/man1 --kind=man | |||
|
|
|||
| .PHONY: generated | |||
| generated: test-unit-update-golden man docs fmt ## generate all files that needs to be generated | |||
There was a problem hiding this comment.
I am a little bit worried to put test-unit-update-golden in generated as this might update golden file when not intended by the user (and thus hide a unwanted change in the output)
There was a problem hiding this comment.
why would it be? this should not happen isnt it ? I mean the point is to have the same exact output unless a code change?
|
/retest |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Some makefile fixes:
lint-yamltarget when doingmake lintgeneratetarget that would includes all the generation targets (ie mandocs/golden)
make fmt, since $() is evaluated in makefile, need to use backquote for subshellexansion