Fix bug about Complete logs not shown for failed TaskRun

[16yuki0702]

Changes

Related issue is #587

This bug seems to be happen from When pod status is failed hasTaskRunFailed method returns error immediately,
so pod's logs can't be shown up.

This fix stop returning error immediately, if pod status is failed just logging error on standard error.

Test yaml files is

apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: tt
spec:
  steps:
    - name: echo
      image: ubuntu
      command:
        - echol
      args:
        - "hello world"
---
apiVersion: tekton.dev/v1alpha1
kind: TaskRun
metadata:
  name: diff-tt
spec:
  taskRef:
    name: tt
---

from this fix, logs can be shown like below.

$ tkn tr ls
NAME       STARTED          DURATION     STATUS               
diff-tt2   45 minutes ago   10 seconds   Succeeded   
diff-tt    53 minutes ago   9 seconds    Failed 

$ tkn tr logs diff-tt
task tt has failed: "step-echo" exited with code 1 (image: "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"); for logs run: kubectl -n default logs diff-tt-pod-h2gwv -c step-echo
[echo] {"level":"info","ts":1581057041.4130957,"logger":"fallback-logger","caller":"logging/config.go:69","msg":"Fetch GitHub commit ID from kodata failed: \"KO_DATA_PATH\" does not exist or is empty"}
[echo] 2020/02/07 06:30:42 Error executing command: exec: "echol": executable file not found in $PATH

container step-echo has failed  : [{"name":"","digest":"","key":"StartedAt","value":"2020-02-07T06:30:42Z","resourceRef":{}}]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Regenerate the manpages and docs with make docs and make man if needed.
• Run the code checkers with make check
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

[tekton-robot]

Hi @16yuki0702. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[piyush-garg]

/ok-to-test

[danielhelfand]

So, when I use the example task/taskrun you used for testing, (i.e., tt, diff-tt), tkn v0.7.1 does already have this behavior without this change.

[16yuki0702]

Really??
Umm... I tested this on revision 22351666497231290ddaa5225bf73dc045db964a
and got this result.

$ tkn tr logs diff-tt
Error: task tt has failed: "step-echo" exited with code 1 (image: "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"); for logs run: kubectl -n default logs diff-tt-pod-h2gwv -c step-echo

it seems pod's log didn't show up...
it is not related with cli version 🤔 ??
I'll try update pipeline version and test again 🤔

[16yuki0702]

I updated pipeline latest and test it again with tkn v0.7.1, but got same result, I can't see any pod logs.

$ tkn tr logs diff-tt
Error: task tt has failed: "step-echo" exited with code 1 (image: "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"); for logs run: kubectl -n default logs diff-tt-pod-r6shz -c step-echo

Umm... why the results are different 🤔??
I got any mistake or misunderstanding 🤔??

[danielhelfand]

I updated pipeline latest and test it again with tkn v0.7.1, but got same result, I can't see any pod logs.

$ tkn tr logs diff-tt
Error: task tt has failed: "step-echo" exited with code 1 (image: "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"); for logs run: kubectl -n default logs diff-tt-pod-r6shz -c step-echo

Umm... why the results are different 🤔??
I got any mistake or misunderstanding 🤔??

Interestingly, it appears there is a difference between tkn tr logs name -f and tkn tr logs name. With -f, I see the logs. Without it, I do not.

[danielhelfand]

Yes, it looks like the difference occurs between going through readAvailableLogs and readLiveLogs so my mistake. This is a good find.

[16yuki0702]

Ahh...!! I totally understood! thank you very much!!

Actually readAvailableLogs should not check pod status like readLiveLogs 🤔??

[chmouel]

What version of kubernetes/openshift do you use ? I have seen some differences between servers version (or at least openshift 4.2 and 4.3)

[16yuki0702]

What version of kubernetes/openshift do you use ?

I use kubernetes v.1.15.5 (Docker Desktop on Mac).

I have seen some differences between servers version (or at least openshift 4.2 and 4.3)

Oops... what kind of difference 🤔??

[danielhelfand]

/lgtm

I do wonder if there's more to #587 than this, but I think there's no doubt that this helps to address it.

[chmouel]

@16yuki0702 sorry i miss-understood the issue with tektoncd/pipeline#2028

[chmouel]

/lgtm
/approve

Thanks 👍🏼🔥

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chmouel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment