-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipeline version information #703
Add pipeline version information #703
Conversation
/cc @waveywaves |
@chmouel: GitHub didn't allow me to request PR reviews from the following users: waveywaves. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dc1463b
to
7cea628
Compare
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
7cea628
to
2faf093
Compare
The following is the coverage report on pkg/.
|
2faf093
to
3f066ad
Compare
The following is the coverage report on pkg/.
|
Tested this out against a 1.10.1 release, works great !
if tekton-pipelines namespace doesn't exist
|
@waveywaves and for completion, it would not show anything if it can't connect and get the server information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor detail noted below. I also tested with earlier version (0.9.2), and works great!
Add pipeline service version information to `tkn pipeline version`. The logic has been imported from dashboard https://git.io/JvC4h I don't have a full test for it, since the machinery to fake a Deployment is quite tedious to import/implement and this is not used anywhere else. Closes tektoncd#463 Signed-off-by: Chmouel Boudjnah <[email protected]>
3f066ad
to
750d3c5
Compare
The following is the coverage report on pkg/.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add pipeline service version information to
tkn pipeline version
. The logichas been imported from dashboard https://git.io/JvC4h
I don't have a full test for it, since the machinery to fake a Deployment is
quite tedious to import/implement and this is not used anywhere else.
Moved the version tests to use
golden
Closes #463
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docs
andmake man
if needed.make check
See the contribution guide
for more details.
Release Notes