Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline version information #703

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Feb 11, 2020

Add pipeline service version information to tkn pipeline version. The logic
has been imported from dashboard https://git.io/JvC4h

I don't have a full test for it, since the machinery to fake a Deployment is
quite tedious to import/implement and this is not used anywhere else.

Moved the version tests to use golden

Closes #463

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 11, 2020
@chmouel
Copy link
Member Author

chmouel commented Feb 11, 2020

/cc @waveywaves

@tekton-robot
Copy link
Contributor

@chmouel: GitHub didn't allow me to request PR reviews from the following users: waveywaves.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @waveywaves

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chmouel chmouel force-pushed the issue-463-feature-request-tkn-pipeline-version branch from dc1463b to 7cea628 Compare February 11, 2020 13:53
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/version/version.go 73.6% 76.3% 2.7

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/version/version.go 73.6% 76.3% 2.7

@chmouel chmouel force-pushed the issue-463-feature-request-tkn-pipeline-version branch from 7cea628 to 2faf093 Compare February 11, 2020 14:15
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/version/version.go 73.6% 76.3% 2.7

@chmouel chmouel force-pushed the issue-463-feature-request-tkn-pipeline-version branch from 2faf093 to 3f066ad Compare February 11, 2020 15:26
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/version/version.go 73.6% 76.3% 2.7

@waveywaves
Copy link
Member

waveywaves commented Feb 11, 2020

Tested this out against a 1.10.1 release, works great !

$ tkn version
Client version: dev
Server version: v0.10.1

if tekton-pipelines namespace doesn't exist

$ tkn version
Client version: dev
Server version: unknown

@chmouel
Copy link
Member Author

chmouel commented Feb 11, 2020

@waveywaves and for completion, it would not show anything if it can't connect and get the server information.

Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor detail noted below. I also tested with earlier version (0.9.2), and works great!

pkg/cmd/version/version.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
Add pipeline service version information to `tkn pipeline version`. The logic
has been imported from dashboard https://git.io/JvC4h

I don't have a full test for it, since the machinery to fake a Deployment is
quite tedious to import/implement and this is not used anywhere else.

Closes tektoncd#463

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel force-pushed the issue-463-feature-request-tkn-pipeline-version branch from 3f066ad to 750d3c5 Compare February 11, 2020 15:52
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/version/version.go 73.6% 76.3% 2.7

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielhelfand,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit c36b6ce into tektoncd:master Feb 12, 2020
@chmouel chmouel deleted the issue-463-feature-request-tkn-pipeline-version branch February 12, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: tkn pipeline version
6 participants