Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring log writer. #709

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Refactoring log writer. #709

merged 1 commit into from
Feb 19, 2020

Conversation

16yuki0702
Copy link
Member

@16yuki0702 16yuki0702 commented Feb 12, 2020 •
edited
Loading

Changes

Related issue is #708

moving pkg/cmd/taskrun/log_writer.go and pkg/cmd/pipelinerun/log_writer.go into same package.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

just refactoring the code

@tekton-robot
Copy link
Contributor

Hi @16yuki0702. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2020
16yuki0702
16yuki0702 commented Feb 12, 2020
View reviewed changes
pkg/cmd/taskrun/logs_test.go Outdated
@@ -258,8 +258,8 @@ func TestLog_taskrun_logs(t *testing.T) {
output, _ := fetchLogs(trlo)

expectedLogs := []string{
"[writefile-step] wrote a file\n",
"[nop] Build successful\n",
"[output-task : writefile-step] wrote a file\n",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why only taskrun's log didn't include task name on log format.

but I think it would be better including task name on log like pipelinerun's log,
so this PR include it together with refactoring.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because it's implicit? i guess I am good with this, I am just worry if someone (ie.: the vscode tekton plugin use tkn as backend) depends on that output...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because it's implicit? i guess I am good with this, I am just worry if someone (ie.: the vscode tekton plugin use tkn as backend) depends on that output...

Ahh.. okay, I'll undo it, thanks !!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because it's implicit? i guess I am good with this, I am just worry if someone (ie.: the vscode tekton plugin use tkn as backend) depends on that output...

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chmouel sorry for late, I undid it !!

@chmouel
Copy link
Member

chmouel commented Feb 12, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2020
@16yuki0702
Copy link
Member Author

/retest

@16yuki0702
Refactoring log writer.
5b44f53 
related issue is tektoncd#708

taskrun's logwriter and pipelinerun's logwriter are almost same code.
It is useful and readable moving these code into same package.
@chmouel
Copy link
Member

chmouel commented Feb 17, 2020

/lgtm

thanks

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
@16yuki0702
Copy link
Member Author

@chmouel Thanks!!
by the way, can I add myself to this list ?
https://github.com/tektoncd/community/blob/master/org/org.yaml

@chmouel
Copy link
Member

chmouel commented Feb 18, 2020 via email •
edited
Loading

@16yuki0702
Copy link
Member Author

16yuki0702 commented Feb 19, 2020 •
edited
Loading

yes!! please do! feel free to send a PR to the members section of the org.yaml.

Thanks!!
I sent a PR tektoncd/community#78

vdemeester
vdemeester approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@tekton-robot tekton-robot merged commit 8db4764 into tektoncd:master Feb 19, 2020
@16yuki0702 16yuki0702 deleted the refactor_log_writer branch February 19, 2020 11:06
@16yuki0702 16yuki0702 mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@chmouel chmouel Awaiting requested review from chmouel

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@vdemeester vdemeester

@chmouel chmouel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@16yuki0702 @tekton-robot @chmouel @vdemeester @hrishin @googlebot