Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump task describe command to v1beta1 #870

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Bump task describe command to v1beta1 #870

merged 1 commit into from
Apr 7, 2020

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Apr 6, 2020 •
edited
Loading

This will move the task describe command to use v1beta1
resource and fix the issue of describe command/
not working

When there is online v1alpha1 resource available
it retrives v1alpha1 and convert to v1beta1
and render template

It involves some refactoring in action package
for better usability

Add testing for both v1beta1 and v1alpha1

Related to #817

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Move task describe to v1beta1 and fix the output

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 6, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/task/task.go 46.7% 50.0% 3.3

vdemeester
vdemeester reviewed Apr 6, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question
/cc @pradeepitm12

pkg/cmd/task/describe.go Show resolved Hide resolved
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/task/task.go 46.7% 50.0% 3.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/task/task.go 46.7% 50.0% 3.3

@piyush-garg piyush-garg force-pushed the fix_817 branch 2 times, most recently from 68244e4 to bdfc734 Compare April 6, 2020 16:34
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/task/task.go 46.7% 28.6% -18.1

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/task/task.go 46.7% 28.6% -18.1

@piyush-garg piyush-garg force-pushed the fix_817 branch 2 times, most recently from f5c6ed7 to 6e40e03 Compare April 7, 2020 05:44
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 7, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/task/task.go 46.7% 28.6% -18.1

pradeepitm12
pradeepitm12 reviewed Apr 7, 2020
View reviewed changes
pkg/task/task.go Outdated Show resolved Hide resolved
@piyush-garg
Bump task describe command to v1beta1
73a0b8b 
This will move the task describe command to use v1beta1
resource and fix the issue of describe command/
not working

When there is online v1alpha1 resource available
it retrives v1alpha1 and convert to v1beta1
and render template

It involves some refactoring in action package
for better usability

Add testing for both v1beta1 and v1alpha1

Related to tektoncd#817
pradeepitm12
pradeepitm12 reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/task/task.go 46.7% 28.6% -18.1

vdemeester
vdemeester approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@tekton-robot tekton-robot merged commit 7c11abd into tektoncd:master Apr 7, 2020
@piyush-garg piyush-garg mentioned this pull request Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand danielhelfand left review comments

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@vdemeester vdemeester vdemeester approved these changes

@chmouel chmouel Awaiting requested review from chmouel

Assignees

@vdemeester vdemeester

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piyush-garg @tekton-robot @vdemeester @pradeepitm12 @danielhelfand @googlebot