Fix lint error and handle properly #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
|
/test pull-tekton-cli-integration-tests |
tekton-robot
added
lgtm
|
/test pull-tekton-cli-integration-tests-0_10 |
|
/hold |
tekton-robot
added
the
do-not-merge/hold
piyush-garg
force-pushed
the
fix_ci_make
branch
from
edca1f4 to
048fb1f
Compare
tekton-robot
added
size/M
piyush-garg
force-pushed
the
fix_ci_make
branch
3 times, most recently
from
758ad8b to
c63469b
Compare
tekton-robot
added
size/L
piyush-garg
force-pushed
the
fix_ci_make
branch
from
c63469b to
3c578af
Compare
Lint errors were not handled properly and CI is passing even with errors This will fix the CI to use proper make targets, handle error and fix lint warnings Skip yaml lint because of some issue in CI
piyush-garg
force-pushed
the
fix_ci_make
branch
from
3c578af to
51c20ca
Compare
piyush-garg
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint errors were not handled properly
and CI is passing even with errors
This will fix the CI to use proper
make targets, handle error
and fix lint warnings
Skip yaml lint because of some issue
in CI
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.