Remove Default Timeout of 1h for Pipeline and Task start #901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #865
This pull request partially addresses #865. It removes default values for
tkn pipeline start
andtkn task start
for the--timeout
option. This will need to eventually also be applied totkn clustertask start
, but there needs to be changes made via #793 before that can take place.Removing the default should be backwards compatible as pipelines will still apply the
1h
default in the event nothing is specified viatkn
. This will also respect thedefault-timeout-minutes
property specified in config-defaults.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
Release Notes