Fix --dry-run with --filename Tests for All Start Commands #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for #911, #924, and #927 introduced some issues for
--dry-run
with--filename
tests for all start commands:Dry run with output=json
is duplicated for each sets of tests. For all commands, the test already exists and is now just running the exact same test againDry Run using --filename
tests to include the version number it is being tested against (i.e.v1beta1
versusv1alpha1
) to avoid confusion that these are the same testsDry Run with output=json -f v1beta1
Task start test to actually use av1beta1
Task as opposed to av1alpha1
TaskSubmitter Checklist
make check
make generated
Release Notes