Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --dry-run with --filename Tests for All Start Commands #937

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix --dry-run with --filename Tests for All Start Commands #937

merged 1 commit into from
Apr 27, 2020

Conversation

danielhelfand
Copy link
Member

@danielhelfand danielhelfand commented Apr 25, 2020

The tests for #911, #924, and #927 introduced some issues for --dry-run with --filename tests for all start commands:

  • Dry run with output=json is duplicated for each sets of tests. For all commands, the test already exists and is now just running the exact same test again
  • Renaming Dry Run using --filename tests to include the version number it is being tested against (i.e. v1beta1 versus v1alpha1) to avoid confusion that these are the same tests
  • Switch the Dry Run with output=json -f v1beta1 Task start test to actually use a v1beta1 Task as opposed to a v1alpha1 Task

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

N/A

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 25, 2020
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@piyush-garg
Copy link
Contributor

/approve
/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@tekton-robot tekton-robot merged commit 60e89c1 into tektoncd:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants