Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve get pipelines version func #947

Merged
merged 1 commit into from
May 14, 2020
Merged

Improve get pipelines version func #947

merged 1 commit into from
May 14, 2020

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Apr 29, 2020 •
edited
Loading

This PR improves the way the GetPipelineVersion func works.

It does so by adding support for standard/recommended k8s labels.
The func also looks in all namespaces by default.

This is part of the implementation for this proposal: tektoncd/pipeline#2497

The related PR in pipelines is here: tektoncd/pipeline#2501

@tekton-robot tekton-robot requested review from chmouel and hrishin April 29, 2020 14:23
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2020
@eddycharly
Copy link
Member Author

/cc @vdemeester

@tekton-robot tekton-robot requested a review from vdemeester April 29, 2020 14:24
@eddycharly eddycharly force-pushed the get-pipelines-version branch from 571cee6 to 4237a13 Compare April 29, 2020 14:27
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/version/version.go 100.0% 33.3% -66.7

@eddycharly eddycharly changed the title Improve get pipelines version func [WIP] Improve get pipelines version func Apr 29, 2020
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/version/version.go 100.0% 87.9% -12.1

@eddycharly eddycharly force-pushed the get-pipelines-version branch 2 times, most recently from 963aa74 to 457b862 Compare April 29, 2020 19:25
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/version/version.go 100.0% 87.9% -12.1

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/version/version.go 100.0% 90.9% -9.1

@eddycharly eddycharly force-pushed the get-pipelines-version branch from 457b862 to 0421988 Compare April 29, 2020 19:31
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/version/version.go 100.0% 90.9% -9.1

@eddycharly eddycharly force-pushed the get-pipelines-version branch from 0421988 to 007dde1 Compare April 29, 2020 19:36
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/version/version.go 100.0% 90.9% -9.1

@eddycharly eddycharly changed the title [WIP] Improve get pipelines version func Improve get pipelines version func Apr 29, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2020
chmouel
chmouel reviewed May 7, 2020
View reviewed changes
pkg/version/version.go Outdated Show resolved Hide resolved
chmouel
chmouel reviewed May 7, 2020
View reviewed changes
Copy link
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@eddycharly eddycharly force-pushed the get-pipelines-version branch from 007dde1 to 34a5edb Compare May 14, 2020 12:50
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
@eddycharly eddycharly requested a review from chmouel May 14, 2020 12:51
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/version/version.go 100.0% 90.6% -9.4

vdemeester
vdemeester approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @savitaashture

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2020
@tekton-robot tekton-robot merged commit 27f9e03 into tektoncd:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@hrishin hrishin Awaiting requested review from hrishin

@chmouel chmouel Awaiting requested review from chmouel

@savitaashture savitaashture Awaiting requested review from savitaashture

Assignees

@vdemeester vdemeester

@chmouel chmouel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eddycharly @tekton-robot @vdemeester @chmouel