fix task start with file #964
Conversation
tekton-robot
added
the
size/L
| @@ -129,7 +129,6 @@ func SpecConvertDown(spec *v1beta1.TaskSpec) *v1alpha1.TaskSpec { | |||
| downTaskSpec.Workspaces = spec.Workspaces | |||
| downTaskSpec.Results = spec.Results | |||
| downTaskSpec.Resources = spec.Resources | |||
| downTaskSpec.Params = spec.Params | |||
There was a problem hiding this comment.
v1alpha1 taskspec will have params in Sepc.Inputs.Params
| @@ -36,8 +36,6 @@ func Create(c *cli.Clients, tr *v1beta1.TaskRun, opts metav1.CreateOptions, ns s | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| v1alpha1TaskRun.Kind = "TaskRun" | |||
There was a problem hiding this comment.
Kind and APIVersion is already added in the ConvertDown func.
|
The following is the coverage report on the affected files.
|
|
/retest |
There was a problem hiding this comment.
/lgtm
We should follow up with an e2e test on this for starting a Task with -f.
Is this pr going to include tkn pipeline start fixes, or was that not affected by #959?
|
The following is the coverage report on the affected files.
|
Close #959 This fixes task start with file command. Note: to start a task from file params needs to have its type speficed, in case of existing task in cluster type is appended by the controller. Signed-off-by: Pradeep Kumar <[email protected]>
Thanks for taking the time to review this. |
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-cli-integration-tests |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Close #959
This fixes task start with file command.
Note: to start a task from file params needs to have its type
speficed, in case of existing task in cluster type is appended by
the controller.
Signed-off-by: Pradeep Kumar [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes