Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0007: Conditions Beta - Mark as Implemented #448

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 3, 2021

This change updates TEP-0007: Conditions Beta:

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2021
@jerop
Copy link
Member Author

jerop commented Jun 3, 2021

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 3, 2021
@jerop jerop changed the title TEP-0007: Conditions Beta TEP-0007: Conditions Beta - Mark as Implemented Jun 3, 2021
@jerop jerop force-pushed the update-conditions-beta branch from ee84ea8 to 1cec4c7 Compare June 3, 2021 19:37
This change updates [TEP-0007: Conditions Beta](https://github.com/tektoncd/community/blob/main/teps/0007-conditions-beta.md):
- TEP status is implemented - was implemented in tektoncd/pipeline#3135
- _skipping_ is addressed in [TEP-0059: Skipping Strategies](https://github.com/tektoncd/community/blob/main/teps/0059-skipping-strategies.md)
@jerop jerop force-pushed the update-conditions-beta branch from 1cec4c7 to 83e02f7 Compare June 3, 2021 19:52
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@ghost
Copy link

ghost commented Jun 14, 2021

/lgtm

@tekton-robot tekton-robot assigned ghost Jun 14, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@tekton-robot tekton-robot merged commit 350767a into tektoncd:main Jun 14, 2021
@jerop jerop deleted the update-conditions-beta branch January 6, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Implemented
Development

Successfully merging this pull request may close these issues.

3 participants