Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0133] Configure Default Resolver #972

Merged

Conversation

QuanZhang-William
Copy link
Member

This commit adds a new TEP: Configure Default Resolver.

This commit adds proposal and implementation details to introduce a new field default-resolver-type in the ConfigMap to configure the default resolver type in Tekton. The design fulfills the requirement of feature request #5907

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Mar 3, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2023
@JeromeJu
Copy link
Member

JeromeJu commented Mar 6, 2023

/assign @jerop

@QuanZhang-William QuanZhang-William force-pushed the configure-default-resolver branch from 2148ee5 to ca92549 Compare March 6, 2023 19:00
@QuanZhang-William QuanZhang-William changed the title [TEP-0132] Configure Default Resolver [TEP-0133] Configure Default Resolver Mar 6, 2023
@QuanZhang-William QuanZhang-William force-pushed the configure-default-resolver branch from ca92549 to 0369498 Compare March 6, 2023 19:04
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teps/0133-configure-default-resolver.md Show resolved Hide resolved
teps/0133-configure-default-resolver.md Outdated Show resolved Hide resolved
teps/0133-configure-default-resolver.md Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@QuanZhang-William QuanZhang-William force-pushed the configure-default-resolver branch 2 times, most recently from 060327d to 0773fb8 Compare March 6, 2023 19:58
teps/0133-configure-default-resolver.md Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@QuanZhang-William QuanZhang-William force-pushed the configure-default-resolver branch from 0773fb8 to bb2bf2c Compare March 7, 2023 18:29
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2023
This commit adds a new TEP: Configure Default Resolver.

This commit adds proposal and implementation details to introduce a new field `default-resolver-type` in the ConfigMap to configure the default resolver type in Tekton. The design fulfills the requirement of [feature request #5907][#5907]

/kind tep

[#5907]: tektoncd/pipeline#5907
@QuanZhang-William QuanZhang-William force-pushed the configure-default-resolver branch from bb2bf2c to c279e7e Compare March 7, 2023 18:31
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2023
@jerop
Copy link
Member

jerop commented Mar 7, 2023

/assign @abayer
/assign @vdemeester

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This design was discussed at API WG and meets the approval requirements

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@tekton-robot tekton-robot merged commit f61e925 into tektoncd:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants