Skip to content

Commit

Permalink
Downgrade react-router-dom-v5-compat due to breaking change
Browse files Browse the repository at this point in the history
`[email protected]` introduces a breaking change that
affects behaviour of `generatePath`. The presence of the `?` in the URL
now triggers the new 'optional route segments' behaviour, and the `?`
is given special meaning. This results in broken URLs as named placeholders
in the query string are no longer replaced, e.g. `:pipelineName` is output
as-is in the URL instead of being replaced with the value of the provided
`pipelineName` param.

Updating the Dashboard to support this new behaviour will take some time
as it's core to how the routes and URLs used for filtering are implemented.
Rolling back the update for now to unblock other changes.
  • Loading branch information
AlanGreene authored and tekton-robot committed Jan 4, 2023
1 parent 320f319 commit af0b8b5
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 24 deletions.
46 changes: 23 additions & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"react-hot-loader": "^4.13.1",
"react-intl": "^6.2.5",
"react-router-dom": "^5.3.4",
"react-router-dom-v5-compat": "^6.6.1",
"react-router-dom-v5-compat": "^6.4.5",
"reconnecting-websocket": "^4.4.0"
},
"devDependencies": {
Expand Down

0 comments on commit af0b8b5

Please sign in to comment.