Update YAML editor to provide default content #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/feature
If the user switches to YAML mode in the Create PipelineRun page we should not present them with an empty editor. At the very least we should pre-populate it with the basic outline of a PipelineRun, i.e. `apiVersion`, `kind`, `metadata` with default name + namespace placeholder, `spec`. If the user has already updated the form before switching to YAML mode, preserve their selected inputs and display the corresponding YAML so they can continue editing as needed. Remove unused code from the YAML editor related to loading of the Pipeline resource.
AlanGreene
force-pushed
the
create_yaml_forminputs
branch
from
78c13bf to
2df075d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related to #2437
If the user switches to YAML mode in the Create PipelineRun page we should not present them with an empty editor. At the very least we should prepopulate it with the basic outline of a PipelineRun, i.e.
apiVersion,kind,metadatawith default name + namespace placeholder,spec.If the user has already updated the form before switching to YAML mode, preserve their selected inputs and display the corresponding YAML so they can continue editing as needed.
Remove unused code from the YAML editor related to loading of the Pipeline resource.
For example, the following form:
generated this YAML:
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes