Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

[helm/dashboard] Add support for namespace bound or cluster wide RBAC #536

Closed
wants to merge 1 commit into from

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented May 11, 2020

Changes

This pull request adds support for namespaces bound or cluster wide RBAC.

The user can choose to limit the namespaces that can be accessed by the dashboard by the dashboard backend.

If no namespaces are set, the deployment is considered cluster wide and the entire cluster is accessible.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mnuttall
You can assign the PR to them by writing /assign @mnuttall in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2020
@eddycharly
Copy link
Member Author

/retest

@eddycharly
Copy link
Member Author

/assign @mnuttall
/cc @vdemeester

@eddycharly
Copy link
Member Author

/meow
/cc @afrittoli

@tekton-robot
Copy link

@eddycharly: cat image

In response to this:

/meow
/cc @afrittoli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot requested a review from afrittoli May 15, 2020 12:05
@eddycharly
Copy link
Member Author

Closing. Too early for that.

@eddycharly eddycharly closed this May 16, 2020
@eddycharly eddycharly deleted the role-binding branch May 25, 2020 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants