This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
enable presubmit tests on experimental repository #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
approved
vdemeester
force-pushed
the
enable-presubmit
branch
2 times, most recently
from
5b5bb37 to
7af40f9
Compare
tekton-robot
added
size/XXL
vdemeester
force-pushed
the
enable-presubmit
branch
21 times, most recently
from
dea04a6 to
c0d157c
Compare
vdemeester
force-pushed
the
enable-presubmit
branch
8 times, most recently
from
3a5f4f6 to
560b715
Compare
10 tasks
Tests will run for all PRs, but it should run only the folder that have changed files. If files are changed accross folders, it will run all of the tests. Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
enable-presubmit
branch
5 times, most recently
from
ad5710d to
329addb
Compare
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
enable-presubmit
branch
from
329addb to
485f1a8
Compare
vdemeester
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
Looks good to me - so we already have the Go test command here and hence it's not seen in this diff. The plumbing change is already merged here. /approve @iancoffey FYI! 🤞 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-roberts, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests will run for all PRs, but it should run only the folder that
have changed files. If files are changed accross folders, it will run
all of the tests.
Fixes #59 although, we'll need to add actual integration tests function
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.