Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Update OWNERS on operator 🙃 #559

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 9, 2021

Changes

This changes does 3 things:

  • Removes @sthaha from approvers (as inactive for a long time 🙏)
  • Move @sm43 to approvers
  • Adds @concaf to reviewers

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

This changes does 3 things:
- Removes @sthaha from approvers (as inactive for a long time 🙏)
- Move @sm43 to approvers
- Adds @concaf to reviewers

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 9, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2021
@nikhil-thomas
Copy link
Member

/approve
/lgtm
/meow

@tekton-robot
Copy link
Contributor

@nikhil-thomas: cat image

In response to this:

/approve
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2021
@tekton-robot tekton-robot merged commit 179cdde into tektoncd:main Dec 9, 2021
@vdemeester vdemeester deleted the update-owners branch December 9, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants