[openshift] Use label selectors to find RBAC instalelr set name #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use labelselectr based list query to find the existing RBAC installerset name, instead of looking it up from a map in tektonconfig.status. Kubernetes being "optimistically consistent" we cannot guarantee that the value in tektonconfig status will be updated withing a predictable time or that whether/when the update will pass or fail. List queries based on label selectors is more reliable Signed-off-by: Nikhil Thomas <[email protected]>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
|
/lgtm |
sm43
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use labelselector based list query to find the existing RBAC installerset
name, instead of looking it up from a map in tektonconfig.status.
Kubernetes being "optimistically consistent", we cannot guarantee that
the value in tektonconfig.status will be updated within a predictable
time or that whether/when the update might pass or fail.
List queries based on label selectors is more reliable
Signed-off-by: Nikhil Thomas [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes