Fixes Hub version to latest in Makefile

[PuneetPunamiya]

Initially, Hub version was hard coded in makefile to fetch
the specific version and after each release to get the latest
version we had to update the version in the Makefile

Hence this patch fixes the version to latest where in the script
it fetches the latest Hub version

Signed-off-by: Puneet Punamiya [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

[nikhil-thomas]

/hold

this jq -r could get us into a tricky situation.

This patch will get chronologically latest version of hub, not the semver latest.

ie
if we publish

• 1.7.0 today
• 1.8.0 tomorrow
• 1.7.1 day after tomorrow.

on day after tomorrow this patch will return 1.7.1 (chronological latest)

hence i had to use sort -V in here (-V for version aware sort)

[nikhil-thomas]

/hold

this jq -r could get us into a tricky situation.

This patch will get chronologically latest version of hub, not the semver latest.

ie if we publish

• 1.7.0 today
• 1.8.0 tomorrow
• 1.7.1 day after tomorrow.

on day after tomorrow this patch will return 1.7.1 (chronological latest)

hence i had to use sort -V in here (-V for version aware sort)

for example

$ curl -sL https://api.github.com/repos/tektoncd/pipeline/releases | jq -r ".[].tag_name"                                                                                                                                                        255 ↵
v0.35.1
v0.35.0
v0.34.1
v0.34.0
v0.32.4
v0.32.3
v0.31.4
v0.31.3
v0.30.4
v0.30.3
v0.33.4
v0.33.3
v0.33.2
v0.33.1
v0.33.0
v0.32.2
v0.31.2
v0.30.2
v0.32.1
v0.31.1
v0.30.1
v0.29.1

see v0.32.x releases appearing 0.33.x.
so on any day if there is a datewise newer patch release for an older version (eg: v0.32.x), then the patch in this pr will retrieve that version instead of the latest version (eg: v0.33.x).

🧑‍💻 👉 this situation could be solved using the bash sort command with its -V (version aware sort flag).

eg:

curl -sL https://api.github.com/repos/tektoncd/pipeline/releases | jq ".[].tag_name"  | sort -Vr
"v0.35.1"
"v0.35.0"
"v0.34.1"
"v0.34.0"
"v0.33.4"
"v0.33.3"
"v0.33.2"
"v0.33.1"
"v0.33.0"
"v0.32.4"
"v0.32.3"
"v0.32.2"
"v0.32.1"
"v0.32.0"
"v0.31.4"
"v0.31.3"
"v0.31.2"
"v0.31.1"
"v0.31.0"
"v0.30.4"
"v0.30.3"
"v0.30.2"
"v0.30.1"
"v0.30.0"
"v0.29.1"

@PuneetPunamiya could you drop the -r from jq and pipe the output of jq through sort -Vr

[PuneetPunamiya]

@nikhil-thomas I have updated the patch could you please take a final look at it once ?

[sm43]

/approve

[vdemeester]

/lgtm

[piyush-garg]

/lgtm

[nikhil-thomas]

/hold cancel
/lgtm
/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas, sm43, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nikhil-thomas,sm43,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment