Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TektonConfig] Allows user to set priorityClassName parameter #797

Merged
merged 1 commit into from
Jun 27, 2022
Merged

[TektonConfig] Allows user to set priorityClassName parameter #797

merged 1 commit into from
Jun 27, 2022

Conversation

guhaneswaran
Copy link
Contributor

@guhaneswaran guhaneswaran commented May 23, 2022 •
edited by sm43
Loading

Changes

Allows user to set priorityClassName parameter for the Tekton resources created.

In TektonConfig CR, allows .spec.config.priorityClassName as a new optional field where users can set the priorityClassName

However, externally the necessary Kubernetes PriorityClass needs to be created accordingly to allow successful pod scheduling, else the pod will not come into Running stage

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

The PR does only allow changes in the parent field which takes the same priorityclass for all the Tekton Resources and doesnt allow user to set individually for each resource. These will be covered in the next PR

Fixes part of #580

@guhaneswaran
[TektonConfig] Allows user to set priorityClassName parameter for
fcddaf2 
the tekton resources created.

In TektonConfig CR, allows  `.spec.config.priorityClassName` as a
new optional field where users can set the priorityClassName.

However, extenally the necessary Kubernetes PriorityClass needs to
be created accordingly to allow successful pod scheduling, else the
pod will not come into Running stage
@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 23, 2022
@tekton-robot
Copy link
Contributor

Hi @guhaneswaran. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2022
@guhaneswaran
Copy link
Contributor Author

@nikhil-thomas , would you be able to review/approve this PR

@sm43
Copy link
Member

sm43 commented May 23, 2022

Thank you for the PR 😺
/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 73.8% 73.9% 0.1

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 23, 2022
@sm43
Copy link
Member

sm43 commented May 24, 2022

/approve

1 similar comment
@sm43
Copy link
Member

sm43 commented May 24, 2022

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@sm43
Copy link
Member

sm43 commented May 24, 2022

/cc @savitaashture @pradeepitm12 @piyush-garg

@sm43 sm43 requested a review from nikhil-thomas May 24, 2022 04:08
vdemeester
vdemeester approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @nikhil-thomas

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sm43, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhil-thomas
Copy link
Member

/lgtm
👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2022
@pradeepitm12
Copy link
Contributor

/lgtm

@sm43
Copy link
Member

sm43 commented Jun 27, 2022

/retest

@tekton-robot tekton-robot merged commit 823835a into tektoncd:main Jun 27, 2022
@vdemeester vdemeester mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@savitaashture savitaashture Awaiting requested review from savitaashture

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

Assignees

@nikhil-thomas nikhil-thomas

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guhaneswaran @tekton-robot @sm43 @nikhil-thomas @pradeepitm12 @vdemeester