Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors update logic for TektonPipeline reconciler #841

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Refactors update logic for TektonPipeline reconciler #841

merged 1 commit into from
Jun 17, 2022

Conversation

PuneetPunamiya
Copy link
Member

  • Initially in pipeline installerset the annotation lastAppliedHash
    of TektonPipeline spec was stored instead of hash of spec of
    TektonInstallerSet

  • Hence this patch stores the hash of spec of TektonInstallerSet
    as annotations to check if an upgrade is required for an installerset

Signed-off-by: Puneet Punamiya [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 14, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 14, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/shared/tektoninstallerset/install.go 50.0% 62.1% 12.1

@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-operator-unit-tests

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/shared/tektoninstallerset/install.go 50.0% 62.1% 12.1

@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-operator-integration-tests

@nikhil-thomas
Copy link
Member 

2022/06/14 10:14:54 main.go:319: Something went wrong: failed to acquire k8s binaries: failed to get gke version from channel regular: error during gcloud beta container get-server-config --project=tekton-prow-11 --format=json(channels) --region=us-central1: exit status 1

i think this is a gke issue.

@nikhil-thomas
Copy link
Member

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@PuneetPunamiya
Refactors update logic for TektonPipeline reconciler
9273832 
Initially in pipeline installerset the annotation `lastAppliedHash`
of TektonPipeline spec was stored instead of hash of spec of
TektonInstallerSet

Hence this patch stores the hash of spec of TektonInstallerSet
as annotations to check if an upgrade is required for an installerset

Signed-off-by: Puneet Punamiya <[email protected]>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/shared/tektoninstallerset/install.go 50.0% 62.1% 12.1

@nikhil-thomas nikhil-thomas removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 17, 2022
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@tekton-robot tekton-robot merged commit 07c674a into tektoncd:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil-thomas nikhil-thomas nikhil-thomas left review comments

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PuneetPunamiya @tekton-robot @nikhil-thomas @piyush-garg